Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card

Krzysztof Kozlowski
2024-08-27T13:27:12Z

On 26/08/2024 22:53, Frank Li wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Add wm8962 sound card which connects to sai3.

...

> +
> &usbotg1 {
> dr_mode = "otg";
> hnp-disable;
> @@ -758,6 +816,26 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07 0x31e
> >;
> };
>
> + pinctrl_sai3: sai3grp {
> + fsl,pins = <
> + MX93_PAD_GPIO_IO26__SAI3_TX_SYNC 0x31e
> + MX93_PAD_GPIO_IO16__SAI3_TX_BCLK 0x31e
> + MX93_PAD_GPIO_IO17__SAI3_MCLK 0x31e
> + MX93_PAD_GPIO_IO19__SAI3_TX_DATA00 0x31e
> + MX93_PAD_GPIO_IO20__SAI3_RX_DATA00 0x31e
> + >;
> + };
> +
> + pinctrl_sai3_sleep: sai3grpsleep {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof