Re: [PATCH v4] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

Philipp Hortmann
2024-08-27T04:53:28Z

On 8/27/24 02:11, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: multiple assignments should be avoided.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> v4: Squash v1 and v3
> v3: Fix typo in commit message.
> v2: Removed two spaces in front of "=".
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index fc8e7f73b2a4..67c4793e0fc1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -526,7 +526,8 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
> mutex_unlock(&priv->wx_mutex);
>
> if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
> - ieee->pairwise_key_type = ieee->group_key_type = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>