From: Riyan Dhiman <riyandhiman14@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Riyan Dhiman <riyandhiman14@gmail.com>
Subject: [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided
Date: Wed, 28 Aug 2024 01:06:37 +0530 [thread overview]
Message-ID: <20240827193634.3291-4-riyandhiman14@gmail.com> (raw)
Abstract out x86-specific code in ddk750_init_hw() to improve
portability and adhere to kernel coding standards. Replaces
architecture-specific defines with CONFIG_X86 checks.
Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.
Changes made:
- Create a new function sm750le_set_graphic_mode to encapsulate architecture
specifc behaviour.
- Using CONFIG_X86 instead of i386 and x86.
- Added placeholder for non-x86 architectures in sm750le_set_graphic_mode
function.
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 02860d3ec365..23196070bceb 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -210,6 +210,17 @@ unsigned int ddk750_get_vm_size(void)
return data;
}
+static void sm750le_set_graphic_mode(void)
+{
+#ifdef CONFIG_X86
+ outb_p(0x88, 0x3d4);
+ outb_p(0x06, 0x3d5);
+#else
+ /* Implement an alternative method for non-x86 architectures */
+ /* This might involve memory-mapped I/O or other chip-specific methods */
+#endif
+}
+
int ddk750_init_hw(struct initchip_param *p_init_param)
{
unsigned int reg;
@@ -229,11 +240,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
poke32(VGA_CONFIGURATION, reg);
} else {
-#if defined(__i386__) || defined(__x86_64__)
- /* set graphic mode via IO method */
- outb_p(0x88, 0x3d4);
- outb_p(0x06, 0x3d5);
-#endif
+ sm750le_set_graphic_mode();
}
/* Set the Main Chip Clock */
--
2.46.0
next reply other threads:[~2024-08-27 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 19:36 Riyan Dhiman [this message]
2024-08-29 9:54 ` [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-02-12 7:43 Michael Anckaert
2025-02-12 8:00 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827193634.3291-4-riyandhiman14@gmail.com \
--to=riyandhiman14@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox