The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "bigeasy@linutronix.de" <bigeasy@linutronix.de>
To: "Brandt, Oliver - Lenze" <oliver.brandt@lenze.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irq_work: Avoid unnecessary "IRQ work" interrupts
Date: Wed, 28 Aug 2024 16:02:23 +0200	[thread overview]
Message-ID: <20240828140223.P5vGN54Q@linutronix.de> (raw)
In-Reply-To: <1dc4fa0a48b05e14a1ae2a751441ba021ecee286.camel@lenze.com>

On 2024-08-28 13:26:42 [+0000], Brandt, Oliver - Lenze wrote:
> 
> Hmm.... I see. What about calling wake_irq_workd() directly; something
> like
> 
>         if (rt_lazy_work)
>                 wake_irq_workd();
>         else if (!lazy_work || tick_nohz_tick_stopped())
>                 irq_work_raise(work);

this might work but I'm not too sure about it. This will become a
problem if irq_work_queue() is invoked from a path where scheduling is
not possible due to recursion or acquired locks. 

How much of a problem is it and how much you gain by doing so?

> Regards,
> Oliver

Sebastian

  reply	other threads:[~2024-08-28 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 15:45 [PATCH] irq_work: Avoid unnecessary "IRQ work" interrupts Brandt, Oliver - Lenze
2024-08-28  9:37 ` Sebastian Andrzej Siewior
2024-08-28  9:54   ` Sebastian Andrzej Siewior
2024-08-28 13:26     ` Brandt, Oliver - Lenze
2024-08-28 14:02       ` bigeasy [this message]
2024-08-28 14:52         ` Brandt, Oliver - Lenze
2024-09-03  9:26           ` bigeasy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828140223.P5vGN54Q@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.brandt@lenze.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox