From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D1E1891AC; Wed, 28 Aug 2024 15:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724857425; cv=none; b=nZJ/hb793/sa1dObSQWnVFrZKHNe+105T2uKCCw/KOs2ABMWhJ4hBVcdiwNt5RMsduyudUeTXfKZb0jmbvVLlkhTLev49z/xbrodbjyOnoWHLs0VlH+F4tttN95HzXWJZucYfgmywSqHLSIefhj4udn3ECovHQY7rAWctJmaWcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724857425; c=relaxed/simple; bh=yEUS2+We6pYU5E5aUU6qY7JHegaAWPxXgJVKjsaaybw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TRD3qGaVRzBeqV/7llbPB8ZsSRp+pjXyqE/JowRdwCnyHpdJ+y6k6Uv3nORbb6Q6nOieMRiWWiZkmNI7vsrv0IPI/txDNxxdN5Wl56aHJ/+Gft/77B3yD4ERB/dqkw/FbBSd1QDam1/JaTqKrtRKs5W3jPdgvovbPMnZlpcwiqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=geNhUTf6; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=OB5SN3gs; arc=none smtp.client-ip=103.168.172.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="geNhUTf6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OB5SN3gs" Received: from phl-compute-02.internal (phl-compute-02.nyi.internal [10.202.2.42]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 08F6C1151B49; Wed, 28 Aug 2024 11:03:42 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 28 Aug 2024 11:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724857421; x=1724943821; bh=RYAedfyLuVntN+kLSt9YJMUi7beiuO1xRvYSBZFsvXM=; b= geNhUTf6vyHVdZck3OF+RSzjQNIWfNXpFDRRITTuC+K7Tj9j5Lqh8YB9VCHgQem4 /QTGXlxJCkU4rcVrISAIStO1oUgvrQrhgnEqX/kNCQEHvRJN4fRQMmsD7Xn8QgNu kBtkSSs1m0G7i7Pj+6ChpGodhHcATr+hmx0te81UiUxXdEZHYsPjckmDuOF8pV15 tWIJHf+Ge33XabGeg67lSgIUiH2i6bgebe0L9+KvC2hP1IdIOoj9JdNBBbr2cYyL F8HeySqKFH5v5sKuCt1VR+GG0Q4KxmJsVJkYU7HrIqyok5yFz7gKHYjVKDwIfOhB tMZsBbwbw8HW/uNzbtDxRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724857421; x= 1724943821; bh=RYAedfyLuVntN+kLSt9YJMUi7beiuO1xRvYSBZFsvXM=; b=O B5SN3gsPcaVFxiRH0Dvh0noSPMW8CqJd84ThysM+JgmGJng1mXqe+8L+lflD0pyP 8GJdo9arSmgwRvNw/E0oLpcke7/qX5Qs/9TxKGJHGlMZ+5bTlC2NibNnzBxBk2T9 8JP4zMYjxP/eyg+aVKiT5K0P3tVVG9KrbhsJXM36srrScy4ehFZvL9dp4Eddh5hd foBLgGtCffKsL8iw8rVAttNLe74DCmt4sfsxcXSdsa73FryC1kEuCDnzyRDBZ7XQ VWhQbw6scUr0C1z9ytY6BhayZR2XO4rh79yb29qtoP5loiKInv18ailaOoM4yQeo NPGUqOtIf/PL6hgqNviqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefvddgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdej necuhfhrohhmpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhoug gvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrght thgvrhhnpeefhfellefhffejgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvd elieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehn ihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrsh gvpdhnsggprhgtphhtthhopeduhedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep phgruhhlrdgsrghrkhgvrhdrtghtsegsphdrrhgvnhgvshgrshdrtghomhdprhgtphhtth hopehsrdhshhhthihlhihovhesohhmphdrrhhupdhrtghpthhtohepuggrvhgvmhesuggr vhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrd gtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehp rggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoheprghnughrvgifsehluhhnnh drtghhpdhrtghpthhtohepsghijhhurdgurghsrdhjiiessghprdhrvghnvghsrghsrdgt ohhmpdhrtghpthhtoheptghlrghuughiuhdrsggviihnvggrrdhujhessghprdhrvghnvg hsrghsrdgtohhm X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Aug 2024 11:03:39 -0400 (EDT) Date: Wed, 28 Aug 2024 17:03:37 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Paul Barker Cc: Sergey Shtylyov , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Biju Das , Claudiu Beznea , Lad Prabhakar , Mitsuhiro Kimura , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net PATCH v2 2/2] net: ravb: Fix R-Car RX frame size limit Message-ID: <20240828150337.GA3306821@ragnatech.se> References: <20240828102226.223-1-paul.barker.ct@bp.renesas.com> <20240828102226.223-3-paul.barker.ct@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240828102226.223-3-paul.barker.ct@bp.renesas.com> Hi Paul, Thanks for your work. On 2024-08-28 11:22:26 +0100, Paul Barker wrote: > The RX frame size limit should not be based on the current MTU setting. > Instead it should be based on the hardware capabilities. > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Reviewed-by: Sergey Shtylyov > Signed-off-by: Paul Barker Reviewed-by: Niklas Söderlund > --- > drivers/net/ethernet/renesas/ravb_main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 471a68b0146e..b103632de4d4 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -555,8 +555,10 @@ static void ravb_emac_init_gbeth(struct net_device *ndev) > > static void ravb_emac_init_rcar(struct net_device *ndev) > { > + struct ravb_private *priv = netdev_priv(ndev); > + > /* Receive frame limit set register */ I wonder if we also should expand this comment to explain the addition of ETH_FCS_LEN, I have to look this up every time :-) How would you feel about adding something like? /* Set receive frame length * * The length set here described the frame from the destination * address up to and including the CRC data. However only the frame * data, exuding the CRC, are transferred to memory. To allow for * the largest frames add the CRC length to the maximum Rx * descriptor size. */ > - ravb_write(ndev, ndev->mtu + ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN, RFLR); > + ravb_write(ndev, priv->info->rx_max_frame_size + ETH_FCS_LEN, RFLR); > > /* EMAC Mode: PAUSE prohibition; Duplex; RX Checksum; TX; RX */ > ravb_write(ndev, ECMR_ZPF | ECMR_DM | > -- > 2.43.0 > -- Kind Regards, Niklas Söderlund