linux-next: build warning after merge of the vfs-brauner tree

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

fs/stat.c:80: warning: Function parameter or member 'request_mask' not described in 'generic_fillattr'

Introduced by commit

  8fb690f6de31 ("fs: pass the request_mask to generic_fillattr")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Wed, May 24, 2023 at 01:46:23PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> fs/stat.c:80: warning: Function parameter or member 'request_mask' not described in 'generic_fillattr'
> 
> Introduced by commit
> 
>   8fb690f6de31 ("fs: pass the request_mask to generic_fillattr")

Thanks, Jeff will send a new version of the series which should fix
this hopefully.

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build
(htmldocs) produced this warning:

Documentation/filesystems/locking.rst:119: ERROR: Malformed table.
Text in column margin in table line 27.

==============  =============================================
ops             i_rwsem(inode)
==============  =============================================
lookup:         shared
create:         exclusive
link:           exclusive (both)
mknod:          exclusive
symlink:        exclusive
mkdir:          exclusive
unlink:         exclusive (both)
rmdir:          exclusive (both)(see below)
rename:         exclusive (all) (see below)
readlink:       no
get_link:       no
setattr:        exclusive
permission:     no (may not block if called in rcu-walk mode)
get_inode_acl:  no
get_acl:        no
getattr:        no
listxattr:      no
fiemap:         no
update_time:    no
atomic_open:    shared (exclusive if O_CREAT is set in open flags)
tmpfile:        no
fileattr_get:   no or exclusive
fileattr_set:   exclusive
get_offset_ctx: no
==============  =============================================

Introduced by commit

  7a3472ae9614 ("libfs: Add directory operations for stable offsets")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

fs/stat.c:79: warning: Function parameter or member 'request_mask' not described in 'generic_fillattr'

Introduced by commit

  0a6ab6dc6958 ("fs: pass the request_mask to generic_fillattr")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/api-summary:38: fs/super.c:558: ERROR: Unexpected indentation.
Documentation/filesystems/api-summary:38: fs/super.c:559: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/filesystems/api-summary:38: fs/super.c:561: WARNING: Enumerated list ends without a blank line; unexpected unindent.


Introduced by commit

  c9eca69d372c ("fs: add FSCONFIG_CMD_CREATE_EXCL")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

fs/inode.c:759: warning: Excess function parameter 'kill_dirty' description in 'invalidate_inodes'

Introduced by commit

  fc3b2b8e7199 ("fs: simplify invalidate_inodes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/pipe_fs_i.h:132: warning: Function parameter or member 'pipe' not described in 'pipe_has_watch_queue'

Introduced by commit

  7084dde72592 ("fs/pipe: move check to pipe_has_watch_queue()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/api-summary:14: include/linux/fs.h:1655: WARNING: Definition list ends without a blank line; unexpected unindent.
include/linux/fs.h:1658: warning: Function parameter or member 'level' not described in '__sb_write_started'

Introduced by commit

  2a7b49f698d0 ("fs: create __sb_write_started() helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Amir Goldstein]

On Fri, Nov 24, 2023 at 4:13 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/api-summary:14: include/linux/fs.h:1655: WARNING: Definition list ends without a blank line; unexpected unindent.
> include/linux/fs.h:1658: warning: Function parameter or member 'level' not described in '__sb_write_started'
>
> Introduced by commit
>
>   2a7b49f698d0 ("fs: create __sb_write_started() helper")

Christian,

Do you mind folding:

@@ -1648,6 +1648,7 @@ static inline bool
__sb_start_write_trylock(struct super_block *sb, int level)
 /**
  * __sb_write_started - check if sb freeze level is held
  * @sb: the super we write to
+ * @level: the freeze level
  *
  * > 0 sb freeze level is held
  *   0 sb freeze level is not held

Thanks,
Amir.

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (s390
defconfig) produced this warning:

arch/s390/configs/defconfig:626:warning: symbol value 'm' invalid for FSCACHE

Introduced by commit

  9896c4f367fc ("netfs, fscache: Combine fscache with netfs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> 
> After merging the vfs-brauner tree, today's linux-next build (s390
> defconfig) produced this warning:
> 
> arch/s390/configs/defconfig:626:warning: symbol value 'm' invalid for FSCACHE
> 
> Introduced by commit
> 
>   9896c4f367fc ("netfs, fscache: Combine fscache with netfs")

I've fixed the arches that had FSCACHE=m to have NETFS_SUPPORT=m and
FSCACHE=y.

David

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/index.rst:63: WARNING: toctree contains reference to nonexisting document 'filesystems/ntfs'

Introduced by commit

  9c67092ed339 ("fs: Remove NTFS classic")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/coredump.c: In function 'dump_user_range':
fs/coredump.c:923:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
  923 | #define dump_page_copy(src, dst) ((dst), (src))
      |                                        ^
fs/coredump.c:948:58: note: in expansion of macro 'dump_page_copy'
  948 |                         int stop = !dump_emit_page(cprm, dump_page_copy(page, dump_page));
      |                                                          ^~~~~~~~~~~~~~

Introduced by commit

  4630f2caafcd ("coredump: get machine check errors early rather than during iov_iter")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Linus Torvalds]

On Tue, 5 Mar 2024 at 15:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> fs/coredump.c: In function 'dump_user_range':
> fs/coredump.c:923:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
>   923 | #define dump_page_copy(src, dst) ((dst), (src))
>       |                                        ^
> fs/coredump.c:948:58: note: in expansion of macro 'dump_page_copy'
>   948 |                         int stop = !dump_emit_page(cprm, dump_page_copy(page, dump_page));
>       |                                                          ^~~~~~~~~~~~~~
>
> Introduced by commit
>
>   4630f2caafcd ("coredump: get machine check errors early rather than during iov_iter")

Bah. If comes from that

  #define dump_page_copy(src,dst) ((dst),(src))

and I did it that way because I wanted to avoid *another* warning,
namely the "dst not used" thing.

But it would have probably been better to either make it an inline
function, or maybe an explicit cast, eg

  #define dump_page_copy(src,dst) ((void)(dst),(src))

or whatever.

                   Linus

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]

Hi all,

On Tue, 5 Mar 2024 18:48:30 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Tue, 5 Mar 2024 at 15:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > fs/coredump.c: In function 'dump_user_range':
> > fs/coredump.c:923:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
> >   923 | #define dump_page_copy(src, dst) ((dst), (src))
> >       |                                        ^
> > fs/coredump.c:948:58: note: in expansion of macro 'dump_page_copy'
> >   948 |                         int stop = !dump_emit_page(cprm, dump_page_copy(page, dump_page));
> >       |                                                          ^~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> >   4630f2caafcd ("coredump: get machine check errors early rather than during iov_iter")  
> 
> Bah. If comes from that
> 
>   #define dump_page_copy(src,dst) ((dst),(src))
> 
> and I did it that way because I wanted to avoid *another* warning,
> namely the "dst not used" thing.
> 
> But it would have probably been better to either make it an inline
> function, or maybe an explicit cast, eg
> 
>   #define dump_page_copy(src,dst) ((void)(dst),(src))
> 
> or whatever.

This became a build failure for my i386 defconfig build, so I did this:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 6 Mar 2024 15:28:12 +1100
Subject: [PATCH] fix up for "coredump: get machine check errors early rather
 than during iov_iter"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/coredump.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index ea155ffee14c..5353b7ac67f2 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -920,7 +920,10 @@ static struct page *dump_page_copy(struct page *src, struct page *dst)
 
 #define dump_page_alloc() ((struct page *)8) // Not NULL
 #define dump_page_free(x) do { } while (0)
-#define dump_page_copy(src, dst) ((dst), (src))
+static struct page *dump_page_copy(struct page *src, struct page *dst)
+{
+        return NULL;
+}
 
 #endif
 
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Linus Torvalds]

On Tue, 5 Mar 2024 at 20:37, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> +static struct page *dump_page_copy(struct page *src, struct page *dst)
> +{
> +        return NULL;
> +}

No, it needs to be "return src;" not NULL.

That

  #define dump_page_copy(src, dst) ((dst), (src))

was supposed to be a "use 'dst', return 'src'" macro, and is correct
as that. The problem - as you noticed - is that it causes that "left
side of comma expression has no effect" warning.

(Technically it *does* have an effect - exactly the "argument is used"
one - but the compiler warning does make sense).

Actually, the simplest thing to do is probably just

  #define dump_page_free(x) ((void)(x))
  #define dump_page_copy(src, dst) (src)

where the "use" of the 'dump_page' argument is that dump_page_free()
void cast, and dump_page_copy() simply doesn't need to use it at all.

Christian?

            Linus

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2444 bytes --]

Hi all,

On Wed, 6 Mar 2024 15:37:03 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 5 Mar 2024 18:48:30 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > On Tue, 5 Mar 2024 at 15:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > fs/coredump.c: In function 'dump_user_range':
> > > fs/coredump.c:923:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
> > >   923 | #define dump_page_copy(src, dst) ((dst), (src))
> > >       |                                        ^
> > > fs/coredump.c:948:58: note: in expansion of macro 'dump_page_copy'
> > >   948 |                         int stop = !dump_emit_page(cprm, dump_page_copy(page, dump_page));
> > >       |                                                          ^~~~~~~~~~~~~~
> > >
> > > Introduced by commit
> > >
> > >   4630f2caafcd ("coredump: get machine check errors early rather than during iov_iter")    
> > 
> > Bah. If comes from that
> > 
> >   #define dump_page_copy(src,dst) ((dst),(src))
> > 
> > and I did it that way because I wanted to avoid *another* warning,
> > namely the "dst not used" thing.
> > 
> > But it would have probably been better to either make it an inline
> > function, or maybe an explicit cast, eg
> > 
> >   #define dump_page_copy(src,dst) ((void)(dst),(src))
> > 
> > or whatever.  
> 
> This became a build failure for my i386 defconfig build, so I did this:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 6 Mar 2024 15:28:12 +1100
> Subject: [PATCH] fix up for "coredump: get machine check errors early rather
>  than during iov_iter"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/coredump.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/coredump.c b/fs/coredump.c
> index ea155ffee14c..5353b7ac67f2 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -920,7 +920,10 @@ static struct page *dump_page_copy(struct page *src, struct page *dst)
>  
>  #define dump_page_alloc() ((struct page *)8) // Not NULL
>  #define dump_page_free(x) do { } while (0)
> -#define dump_page_copy(src, dst) ((dst), (src))
> +static struct page *dump_page_copy(struct page *src, struct page *dst)
> +{
> +        return NULL;
> +}
>  
>  #endif

On second thoughts I made it return "src" instead of "NULL";

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Tue, Mar 05, 2024 at 08:47:40PM -0800, Linus Torvalds wrote:
> On Tue, 5 Mar 2024 at 20:37, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > +static struct page *dump_page_copy(struct page *src, struct page *dst)
> > +{
> > +        return NULL;
> > +}
> 
> No, it needs to be "return src;" not NULL.
> 
> That
> 
>   #define dump_page_copy(src, dst) ((dst), (src))
> 
> was supposed to be a "use 'dst', return 'src'" macro, and is correct
> as that. The problem - as you noticed - is that it causes that "left
> side of comma expression has no effect" warning.
> 
> (Technically it *does* have an effect - exactly the "argument is used"
> one - but the compiler warning does make sense).
> 
> Actually, the simplest thing to do is probably just
> 
>   #define dump_page_free(x) ((void)(x))
>   #define dump_page_copy(src, dst) (src)
> 
> where the "use" of the 'dump_page' argument is that dump_page_free()
> void cast, and dump_page_copy() simply doesn't need to use it at all.
> 
> Christian?

I would just do it like Stephen did (but returning src ofc) because it's
symmetric to the #ifdef copy_mc_to_kernel definition of dump_page_copy()
and seems easier to read to me.

But I honestly don't care too much. So I'd pick Stephen's change and if
you prefer to do it differently just change it when I send you the pr.

+/*
+ * If we might get machine checks from kernel accesses during the
+ * core dump, let's get those errors early rather than during the
+ * IO. This is not performance-critical enough to warrant having
+ * all the machine check logic in the iovec paths.
+ */
+#ifdef copy_mc_to_kernel
+
+#define dump_page_alloc() alloc_page(GFP_KERNEL)
+#define dump_page_free(x) __free_page(x)
+static struct page *dump_page_copy(struct page *src, struct page *dst)
+{
+       void *buf = kmap_local_page(src);
+       size_t left = copy_mc_to_kernel(page_address(dst), buf, PAGE_SIZE);
+       kunmap_local(buf);
+       return left ? NULL : dst;
+}
+
+#else
+
+/* We just want to return non-NULL; it's never used. */
+#define dump_page_alloc() ERR_PTR(-EINVAL)
+#define dump_page_free(x) ((void)(x))
+static inline struct page *dump_page_copy(struct page *src, struct page *dst)
+{
+       return src;
+}
+#endif

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/xattr.c: In function '__do_sys_setxattrat':
fs/xattr.c:709:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  709 |         return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)args.value,
      |                                                             ^
fs/xattr.c: In function '__do_sys_getxattrat':
fs/xattr.c:855:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  855 |         return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.value, args.size);
      |                                                             ^

Introduced by commit

  89345b0ac5ac ("fs/xattr: add *at family syscalls")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

Hi all,

On Tue, 28 May 2024 10:49:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the vfs-brauner tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/xattr.c: In function '__do_sys_setxattrat':
> fs/xattr.c:709:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   709 |         return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)args.value,
>       |                                                             ^
> fs/xattr.c: In function '__do_sys_getxattrat':
> fs/xattr.c:855:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   855 |         return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.value, args.size);
>       |                                                             ^
> 
> Introduced by commit
> 
>   89345b0ac5ac ("fs/xattr: add *at family syscalls")

This became a build failure in the i386 defconfig build, so I applied
the following fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 May 2024 13:20:29 +1000
Subject: [PATCH] fix up for "fs/xattr: add *at family syscalls"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/xattr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/xattr.c b/fs/xattr.c
index 8e712795ab80..d0d54ae2f9cb 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -706,7 +706,8 @@ SYSCALL_DEFINE6(setxattrat, int, dfd, const char __user *, pathname, unsigned in
 	if (error)
 		return error;
 
-	return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)args.value,
+	return do_setxattrat(dfd, pathname, at_flags, name,
+			     (const void __user *)(unsigned long)args.value,
 			     args.size, args.flags);
 }
 
@@ -852,7 +853,9 @@ SYSCALL_DEFINE6(getxattrat, int, dfd, const char __user *, pathname, unsigned in
 	if (args.flags != 0)
 		return -EINVAL;
 
-	return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.value, args.size);
+	return do_getxattrat(dfd, pathname, at_flags, name,
+			     (void __user *)(unsigned long)args.value,
+			     args.size);
 }
 
 SYSCALL_DEFINE4(getxattr, const char __user *, pathname,
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

> This became a build failure in the i386 defconfig build, so I applied
> the following fix patch.

Fixed in-tree now. Thanks!

Re: linux-next: build warning after merge of the vfs-brauner tree

[Arnd Bergmann]

On Tue, May 28, 2024, at 05:31, Stephen Rothwell wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 28 May 2024 13:20:29 +1000
> Subject: [PATCH] fix up for "fs/xattr: add *at family syscalls"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/xattr.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xattr.c b/fs/xattr.c
> index 8e712795ab80..d0d54ae2f9cb 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -706,7 +706,8 @@ SYSCALL_DEFINE6(setxattrat, int, dfd, const char 
> __user *, pathname, unsigned in
>  	if (error)
>  		return error;
> 
> -	return do_setxattrat(dfd, pathname, at_flags, name, (const void 
> __user *)args.value,
> +	return do_setxattrat(dfd, pathname, at_flags, name,
> +			     (const void __user *)(unsigned long)args.value,
>  			     args.size, args.flags);
>  }
> 

We have a u64_to_user_ptr() helper to make this slightly
more readable.

      Arnd

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Error: Cannot open file fs/netfs/io.c

Introduced by commit

  af6519cfd7c2 ("netfs: Remove fs/netfs/io.c")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/multigrain-ts.rst:83: WARNING: duplicate label filesystems/multigrain-ts:multigrain timestamps, other instance in Documentation/filesystems/multigrain-ts.rst

Introduced by commit

  f9cb86069bad ("Documentation: add a new file documenting multigrain timestamps")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

Hi all,

On Thu, 1 Aug 2024 15:55:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/filesystems/multigrain-ts.rst:83: WARNING: duplicate label filesystems/multigrain-ts:multigrain timestamps, other instance in Documentation/filesystems/multigrain-ts.rst
> 
> Introduced by commit
> 
>   f9cb86069bad ("Documentation: add a new file documenting multigrain timestamps")

Also:

Documentation/filesystems/multigrain-ts.rst: WARNING: document isn't included in any toctree

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Error: Cannot open file fs/netfs/io.c
> 
> Introduced by commit
> 
>   af6519cfd7c2 ("netfs: Remove fs/netfs/io.c")

Ah.

Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c

That needs removing too.

David

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

> Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c
> 
> That needs removing too.

I've removed it now.

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (arm64
defconfig) produced this warning:

<stdin>:1603:2: warning: #warning syscall setxattrat not implemented [-Wcpp]
<stdin>:1606:2: warning: #warning syscall getxattrat not implemented [-Wcpp]
<stdin>:1609:2: warning: #warning syscall listxattrat not implemented [-Wcpp]
<stdin>:1612:2: warning: #warning syscall removexattrat not implemented [-Wcpp]

Presumably introduced by commit

  1810bb54fc6e ("fs/xattr: add *at family syscalls")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/pagemap.h:480: warning: Function parameter or struct member 'index' not described in 'mapping_align_index'

Introduced by commit

  c104d25f8c49 ("filemap: allocate mapping_min_order folios in the page cache")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Pankaj Raghav (Samsung)]

On Mon, Aug 26, 2024 at 04:01:09PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/pagemap.h:480: warning: Function parameter or struct member 'index' not described in 'mapping_align_index'
> 
> Introduced by commit
> 
>   c104d25f8c49 ("filemap: allocate mapping_min_order folios in the page cache")

Oops. That should be a trivial patch. I will send this fix along with
the set_memory_ro() issue in powerpc once that is resolved.

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 55b254d951da7..6c0dde447c980 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -470,6 +470,7 @@ mapping_min_folio_nrpages(struct address_space *mapping)
 /**
  * mapping_align_index() - Align index for this mapping.
  * @mapping: The address_space.
+ * @index: The page index.
  *
  * The index of a folio must be naturally aligned.  If you are adding a
  * new folio to the page cache and need to know what index to give it,
> 
> -- 
> Cheers,
> Stephen Rothwell



-- 
Pankaj Raghav

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Hi all,

On Tue, 13 Aug 2024 13:40:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the vfs-brauner tree, today's linux-next build (arm64
> defconfig) produced this warning:
> 
> <stdin>:1603:2: warning: #warning syscall setxattrat not implemented [-Wcpp]
> <stdin>:1606:2: warning: #warning syscall getxattrat not implemented [-Wcpp]
> <stdin>:1609:2: warning: #warning syscall listxattrat not implemented [-Wcpp]
> <stdin>:1612:2: warning: #warning syscall removexattrat not implemented [-Wcpp]
> 
> Presumably introduced by commit
> 
>   1810bb54fc6e ("fs/xattr: add *at family syscalls")

I am still seeing these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (hmltdocs)
produced this warning:

mm/slab_common.c:385: warning: Excess function parameter 'freeptr_offset' description in 'kmem_cache_create_usercopy'

Introduced by commit

  18dc9b395108 ("mm: add kmem_cache_create_rcu()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Error: Cannot open file /home/sfr/next/next/fs/netfs/io.c

Introduced by commit

  550bc501ff91 ("netfs: Remove fs/netfs/io.c")

$ git grep -w fs/netfs/io.c
Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi all,

On Fri, 6 Sep 2024 18:29:06 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Error: Cannot open file /home/sfr/next/next/fs/netfs/io.c
> 
> Introduced by commit
> 
>   550bc501ff91 ("netfs: Remove fs/netfs/io.c")
> 
> $ git grep -w fs/netfs/io.c
> Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c

That commit is now in Linus' tree, but I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/lockd/svclock.c: In function 'nlmsvc_lock':
fs/lockd/svclock.c:483:34: warning: unused variable 'inode' [-Wunused-variable]
  483 |         struct inode            *inode = nlmsvc_file_inode(file);
      |                                  ^~~~~

Introduced by commit

  81be05940ccc ("NLM/NFSD: Fix lock notifications for async-capable filesystems")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/core-api/folio_queue.rst: WARNING: document isn't included in any toctree

Introduced by commit

  28e8c5c095ec ("netfs: Add folio_queue API documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hi all,

On Tue, 1 Oct 2024 09:11:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the vfs-brauner tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/lockd/svclock.c: In function 'nlmsvc_lock':
> fs/lockd/svclock.c:483:34: warning: unused variable 'inode' [-Wunused-variable]
>   483 |         struct inode            *inode = nlmsvc_file_inode(file);
>       |                                  ^~~~~
> 
> Introduced by commit
> 
>   81be05940ccc ("NLM/NFSD: Fix lock notifications for async-capable filesystems")

This became a build failure in my i386 defconfig build, so I applied
the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 1 Oct 2024 14:12:15 +1000
Subject: [PATCH] fix up for "NLM/NFSD: Fix lock notifications for async-capable filesystems'

from the vfs-brauner tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/lockd/svclock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
index cbb87455a66d..2359347c9fbd 100644
--- a/fs/lockd/svclock.c
+++ b/fs/lockd/svclock.c
@@ -480,7 +480,7 @@ nlmsvc_lock(struct svc_rqst *rqstp, struct nlm_file *file,
 	    struct nlm_host *host, struct nlm_lock *lock, int wait,
 	    struct nlm_cookie *cookie, int reclaim)
 {
-	struct inode		*inode = nlmsvc_file_inode(file);
+	struct inode		*inode __maybe_unused = nlmsvc_file_inode(file);
 	struct nlm_block	*block = NULL;
 	int			error;
 	int			mode;
-- 
2.45.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Tue, Oct 01, 2024 at 02:19:58PM GMT, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 1 Oct 2024 09:11:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the vfs-brauner tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/lockd/svclock.c: In function 'nlmsvc_lock':
> > fs/lockd/svclock.c:483:34: warning: unused variable 'inode' [-Wunused-variable]
> >   483 |         struct inode            *inode = nlmsvc_file_inode(file);
> >       |                                  ^~~~~
> > 
> > Introduced by commit
> > 
> >   81be05940ccc ("NLM/NFSD: Fix lock notifications for async-capable filesystems")
> 
> This became a build failure in my i386 defconfig build, so I applied
> the following patch for today.

Thank you. I just folded that fix into the commit.

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Tue, Oct 01, 2024 at 01:39:20PM GMT, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/core-api/folio_queue.rst: WARNING: document isn't included in any toctree
> 
> Introduced by commit
> 
>   28e8c5c095ec ("netfs: Add folio_queue API documentation")

Added a comment to fix this. Thanks for the report!

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Hi all,

On Wed, 18 Sep 2024 15:24:25 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 6 Sep 2024 18:29:06 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Error: Cannot open file /home/sfr/next/next/fs/netfs/io.c
> > 
> > Introduced by commit
> > 
> >   550bc501ff91 ("netfs: Remove fs/netfs/io.c")
> > 
> > $ git grep -w fs/netfs/io.c
> > Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c  
> 
> That commit is now in Linus' tree, but I am still getting this warning.

I am still seeing that warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Thu, Oct 03, 2024 at 08:45:03AM GMT, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 18 Sep 2024 15:24:25 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 6 Sep 2024 18:29:06 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > > 
> > > Error: Cannot open file /home/sfr/next/next/fs/netfs/io.c
> > > 
> > > Introduced by commit
> > > 
> > >   550bc501ff91 ("netfs: Remove fs/netfs/io.c")
> > > 
> > > $ git grep -w fs/netfs/io.c
> > > Documentation/filesystems/netfs_library.rst:.. kernel-doc:: fs/netfs/io.c  
> > 
> > That commit is now in Linus' tree, but I am still getting this warning.
> 
> I am still seeing that warning.

Pushed new branches now. I didn't do that yesterday.

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Hi Christian,

On Tue, 1 Oct 2024 17:00:49 +0200 Christian Brauner <brauner@kernel.org> wrote:
>
> On Tue, Oct 01, 2024 at 02:19:58PM GMT, Stephen Rothwell wrote:
> > 
> > On Tue, 1 Oct 2024 09:11:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the vfs-brauner tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > > 
> > > fs/lockd/svclock.c: In function 'nlmsvc_lock':
> > > fs/lockd/svclock.c:483:34: warning: unused variable 'inode' [-Wunused-variable]
> > >   483 |         struct inode            *inode = nlmsvc_file_inode(file);
> > >       |                                  ^~~~~
> > > 
> > > Introduced by commit
> > > 
> > >   81be05940ccc ("NLM/NFSD: Fix lock notifications for async-capable filesystems")  
> > 
> > This became a build failure in my i386 defconfig build, so I applied
> > the following patch for today.  
> 
> Thank you. I just folded that fix into the commit.

I am still applying that patch.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build
(htmldocs) produced this warning:

Documentation/filesystems/api-summary:14: include/linux/fs.h:3504: WARNING: Bullet list ends without a blank line; unexpected unindent.

Introduced by commit

  0e152beb5aa1 ("libfs: Create the helper function generic_ci_validate_strict_name()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]

Introduced by commit

  20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Wed, Feb 19, 2025 at 03:34:44PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]
> 
> Introduced by commit
> 
>   20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")
> 

Separating the bullet list should suffice (plus s/recommend/recommended/
for consistency with the rest of docs):

---- >8 ----
diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index 3b6622fbd66be9..cfac50a7258db6 100644
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
 dentry so this doesn't need to be checked.  If the name cannot be found,
 ERR_PTR(-ENOENT) is returned.
 
-** recommend**
+** recommended**
 
 lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
  - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
    ERR_PTR(-ENOENT) is returned instead
  - if LOOKUP_EXCL IS given, then the dentry won't be positive,

Let me know if I should send the formal patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Wed, Feb 19, 2025 at 03:45:41PM +0700, Bagas Sanjaya wrote:
> On Wed, Feb 19, 2025 at 03:34:44PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]
> > 
> > Introduced by commit
> > 
> >   20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")
> > 
> 
> Separating the bullet list should suffice (plus s/recommend/recommended/
> for consistency with the rest of docs):
> 
> ---- >8 ----
> diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
> index 3b6622fbd66be9..cfac50a7258db6 100644
> --- a/Documentation/filesystems/porting.rst
> +++ b/Documentation/filesystems/porting.rst
> @@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
>  dentry so this doesn't need to be checked.  If the name cannot be found,
>  ERR_PTR(-ENOENT) is returned.
>  
> -** recommend**
> +** recommended**
>  
>  lookup_one_qstr_excl() is changed to return errors in more cases, so
> -these conditions don't require explicit checks.
> +these conditions don't require explicit checks:
> +
>   - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
>     ERR_PTR(-ENOENT) is returned instead
>   - if LOOKUP_EXCL IS given, then the dentry won't be positive,
> 
> Let me know if I should send the formal patch.

No, I'll fix it in-tree and fold it.
Thanks.

Re: linux-next: build warning after merge of the vfs-brauner tree

[Bagas Sanjaya]

On 2/19/25 17:04, Christian Brauner wrote:
> On Wed, Feb 19, 2025 at 03:45:41PM +0700, Bagas Sanjaya wrote:
>> Separating the bullet list should suffice (plus s/recommend/recommended/
>> for consistency with the rest of docs):
>>
>> ---- >8 ----
>> diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
>> index 3b6622fbd66be9..cfac50a7258db6 100644
>> --- a/Documentation/filesystems/porting.rst
>> +++ b/Documentation/filesystems/porting.rst
>> @@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
>>   dentry so this doesn't need to be checked.  If the name cannot be found,
>>   ERR_PTR(-ENOENT) is returned.
>>   
>> -** recommend**
>> +** recommended**
>>   
>>   lookup_one_qstr_excl() is changed to return errors in more cases, so
>> -these conditions don't require explicit checks.
>> +these conditions don't require explicit checks:
>> +
>>    - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
>>      ERR_PTR(-ENOENT) is returned instead
>>    - if LOOKUP_EXCL IS given, then the dentry won't be positive,
>>
>> Let me know if I should send the formal patch.
> 
> No, I'll fix it in-tree and fold it.
> Thanks.

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

Re: linux-next: build warning after merge of the vfs-brauner tree

[NeilBrown]

On Wed, 19 Feb 2025, Bagas Sanjaya wrote:
> On Wed, Feb 19, 2025 at 03:34:44PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]
> > 
> > Introduced by commit
> > 
> >   20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")
> > 
> 
> Separating the bullet list should suffice (plus s/recommend/recommended/
> for consistency with the rest of docs):
> 
> ---- >8 ----
> diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
> index 3b6622fbd66be9..cfac50a7258db6 100644
> --- a/Documentation/filesystems/porting.rst
> +++ b/Documentation/filesystems/porting.rst
> @@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
>  dentry so this doesn't need to be checked.  If the name cannot be found,
>  ERR_PTR(-ENOENT) is returned.
>  
> -** recommend**
> +** recommended**
>  
>  lookup_one_qstr_excl() is changed to return errors in more cases, so
> -these conditions don't require explicit checks.
> +these conditions don't require explicit checks:
> +
>   - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
>     ERR_PTR(-ENOENT) is returned instead
>   - if LOOKUP_EXCL IS given, then the dentry won't be positive,
> 
> Let me know if I should send the formal patch.

Thanks a lot for correcting these for me!
NeilBrown


> 
> Thanks.
> 
> -- 
> An old man doll... just what I always wanted! - Clara
> 

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/porting.rst:1186: WARNING: Inline emphasis start-string without end-string. [docutils]

Introduced by commit

  88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Fri, Feb 28, 2025 at 06:55:28PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/filesystems/porting.rst:1186: WARNING: Inline emphasis start-string without end-string. [docutils]
> 
> Introduced by commit
> 
>   88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *")

Fixed with a separate patch since the vfs-6.15.branch is stable.

linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/fs.h:3280: warning: Function parameter or struct member 'name' not described in 'name_contains_dotdot'

Introduced by commit

  0da3e3822cfa ("fs: move name_contains_dotdot() to header")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

On Tue, 17 Jun 2025 15:12:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/fs.h:3280: warning: Function parameter or struct member 'name' not described in 'name_contains_dotdot'
> 
> Introduced by commit
> 
>   0da3e3822cfa ("fs: move name_contains_dotdot() to header")

I am still seeing that warning.  That commit is now in Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-brauner tree

[Christian Brauner]

On Fri, Aug 01, 2025 at 02:38:00PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 17 Jun 2025 15:12:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > include/linux/fs.h:3280: warning: Function parameter or struct member 'name' not described in 'name_contains_dotdot'
> > 
> > Introduced by commit
> > 
> >   0da3e3822cfa ("fs: move name_contains_dotdot() to header")
> 
> I am still seeing that warning.  That commit is now in Linus' tree.

There's a fix in vfs.fixes for this which will go upstream soon.