From: Manisha Singh <masingh.linux@gmail.com>
To: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: philipp.g.hortmann@gmail.com, Manisha Singh <masingh.linux@gmail.com>
Subject: [PATCH v3 2/2] staging: rtl8712: Calculate size from pointer
Date: Thu, 29 Aug 2024 03:51:55 +0530 [thread overview]
Message-ID: <20240828222153.68062-4-masingh.linux@gmail.com> (raw)
In-Reply-To: <20240828222153.68062-2-masingh.linux@gmail.com>
Calculate the size from the pointer instead of struct to adhere to kernel
coding style.
Signed-off-by: Manisha Singh <masingh.linux@gmail.com>
---
Changes since v2:
commit message updated.
Changes since v1:
Broke the patch into 2 different fixes.
drivers/staging/rtl8712/rtl871x_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_io.c b/drivers/staging/rtl8712/rtl871x_io.c
index 378da0aa7f55..20e080e284dd 100644
--- a/drivers/staging/rtl8712/rtl871x_io.c
+++ b/drivers/staging/rtl8712/rtl871x_io.c
@@ -48,7 +48,7 @@ static uint _init_intf_hdl(struct _adapter *padapter,
set_intf_funs = &(r8712_usb_set_intf_funs);
set_intf_ops = &r8712_usb_set_intf_ops;
init_intf_priv = &r8712_usb_init_intf_priv;
- pintf_priv = kmalloc(sizeof(struct intf_priv), GFP_ATOMIC);
+ pintf_priv = kmalloc(sizeof(*pintf_priv), GFP_ATOMIC);
pintf_hdl->pintfpriv = pintf_priv;
if (!pintf_priv)
goto _init_intf_hdl_fail;
--
2.43.0
next prev parent reply other threads:[~2024-08-28 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 22:21 [PATCH v3 1/2] staging: rtl8712: Fix style issues in rtl871x_io.c Manisha Singh
2024-08-28 22:21 ` Manisha Singh [this message]
2024-08-29 5:38 ` [PATCH v3 2/2] staging: rtl8712: Calculate size from pointer Philipp Hortmann
2024-08-29 5:37 ` [PATCH v3 1/2] staging: rtl8712: Fix style issues in rtl871x_io.c Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828222153.68062-4-masingh.linux@gmail.com \
--to=masingh.linux@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox