Re: [PATCH v1 4/5] pinctrl: intel: Implement high impedance support

Andy Shevchenko
2024-08-29T10:53:08Z

On Thu, Aug 29, 2024 at 07:48:19AM +0300, Mika Westerberg wrote:
> On Wed, Aug 28, 2024 at 09:38:37PM +0300, Andy Shevchenko wrote:

...

> > +static int intel_gpio_set_high_impedance(struct intel_pinctrl *pctrl, unsigned int pin)
> > +{
> > + void __iomem *padcfg0;
> > + u32 value;
> > +
> > + padcfg0 = intel_get_padcfg(pctrl, pin, PADCFG0);
> > +
> > + guard(raw_spinlock_irqsave)(&pctrl->lock);
> > +
> > + value = readl(padcfg0);
> > + value = __intel_gpio_set_direction(value, false, false);
> > + writel(value, padcfg0);
> > +
> > + return 0;
>
> Why not make this return void?

No special needs, can be void.

> > +}

...

Thank you for the review! I'll send a v2 soon.

--
With Best Regards,
Andy Shevchenko