Re: [PATCH v1 3/5] pinctrl: intel: Add __intel_gpio_get_direction() helper

Andy Shevchenko
2024-08-29T10:51:01Z

On Thu, Aug 29, 2024 at 01:49:38PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 29, 2024 at 07:46:53AM +0300, Mika Westerberg wrote:
> > On Wed, Aug 28, 2024 at 09:38:36PM +0300, Andy Shevchenko wrote:

...

> > > + * enum - possible pad physical configurations
> > > + *
> >
> > Start with capital letter as others:
> >
> > enum - Possible..
>
> Fixed!
>
> > Also I think we should follow the structs and drop the empty line here
> > (well and for other enums, I don't know how they got there ;-) but it
> > looks better without.
>
> We have the other enum with a blank line. Perhaps removing them in a separate
> patch?

Or I can do it "while at it", it seems to be quite small and likely never
conflicting change...

--
With Best Regards,
Andy Shevchenko