Re: [PATCH v1 0/5] pinctrl: intel: High impedance impl. and cleanups

Andy Shevchenko
2024-09-02T10:46:12Z

On Fri, Aug 30, 2024 at 11:24:06PM +0200, Heiner Kallweit wrote:
> On 28.08.2024 22:00, Andy Shevchenko wrote:
> > On Wed, Aug 28, 2024 at 09:38:33PM +0300, Andy Shevchenko wrote:
> >> We would need a high impedance implementation for a quirk, so here it
> >> is. While doing this series I also noticed a couple of opportunities
> >> to clean up, hence two more patches (1st and 5th).
> >
> > Sorry it took a while to actually start implementing the quirk for your case.
> > Here I'm asking for the following things:
> >
> > 1) what is the marketing name of the device you have problems with?
> > (I believe it's available on the free market, correct?);
> >
> > 2) does it have any BIOS updates and, if it has, does it fix the issue?
> >
> > 3) can you apply patches 2,3,4,5 from this series (the first one is buggy and
> > not needed for you) and replace the hack I mentioned earlier with
> >
> > ret = intel_gpio_set_high_impedance(pctrl, 3);
> > if (ret)
> > return ret;
> >
> > somewhere at the end of intel_pinctrl_probe()?
> >
> > Does it still work as expected?
> >
> >
> In latest series the return value of intel_gpio_set_high_impedance()
> has been removed. With the call to intel_gpio_set_high_impedance()
> changed accordingly this fixes the problem on my system.
> Thanks a lot for your efforts!

Thank you! I will think now, how to make the real quirk (which I may ask you to
test in the future, when it will be ready) that looks and feels not as an ugly
hack.

--
With Best Regards,
Andy Shevchenko