From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<linux@armlinux.org.uk>, <kuba@kernel.org>, <andrew@lunn.ch>,
<hkallweit1@gmail.com>, <richardcochran@gmail.com>,
<rdunlap@infradead.org>, <Bryan.Whitehead@microchip.com>,
<edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <horms@kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink
Date: Thu, 29 Aug 2024 09:49:10 +0200 [thread overview]
Message-ID: <20240829094910.28ccd6ca@device-28.home> (raw)
In-Reply-To: <20240829055132.79638-5-Raju.Lakkaraju@microchip.com>
Hello Raju,
On Thu, 29 Aug 2024 11:21:31 +0530
Raju Lakkaraju <Raju.Lakkaraju@microchip.com> wrote:
> Migrate phy support from phylib to phylink.
>
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
[...]
> +static void lan743x_phylink_disconnect(struct lan743x_adapter *adapter)
> +{
> + struct net_device *netdev = adapter->netdev;
> + struct phy_device *phydev = netdev->phydev;
> +
> + phylink_stop(adapter->phylink);
> + phylink_disconnect_phy(adapter->phylink);
> +
> + if (phydev)
> + if (phy_is_pseudo_fixed_link(phydev))
> + fixed_phy_unregister(phydev);
You shouldn't manually deal with the fixed_phy when using phylink, it
handles fixed links already for you, without a PHY.
Thanks,
Maxime
next prev parent reply other threads:[~2024-08-29 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 5:51 [PATCH net-next V4 0/5] Add support to PHYLINK for LAN743x/PCI11x1x chips Raju Lakkaraju
2024-08-29 5:51 ` [PATCH net-next V4 1/5] net: phylink: Add phylink_set_fixed_link() to configure fixed link state in phylink Raju Lakkaraju
2024-08-30 20:37 ` Andrew Lunn
2024-08-29 5:51 ` [PATCH net-next V4 2/5] net: lan743x: Create separate PCS power reset function Raju Lakkaraju
2024-08-29 5:51 ` [PATCH net-next V4 3/5] net: lan743x: Create separate Link Speed Duplex state function Raju Lakkaraju
2024-08-29 5:51 ` [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink Raju Lakkaraju
2024-08-29 7:49 ` Maxime Chevallier [this message]
2024-08-30 5:36 ` Raju Lakkaraju
2024-08-29 5:51 ` [PATCH net-next V4 5/5] net: lan743x: Add support to ethtool phylink get and set settings Raju Lakkaraju
2024-08-30 20:55 ` Andrew Lunn
2024-09-04 8:23 ` Raju Lakkaraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829094910.28ccd6ca@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=Bryan.Whitehead@microchip.com \
--cc=Raju.Lakkaraju@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox