Re: [PATCH v11 3/4] firmware: ti_sci: Introduce Power Management Ops

Dhruva Gole
2024-08-30T04:35:37Z

On Aug 29, 2024 at 22:16:04 +0200, Markus Schneider-Pargmann wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
>
> Introduce power management ops supported by the TISCI
> Low Power Mode API [1].
>
> 1) TISCI_MSG_LPM_WAKE_REASON
> Get which wake up source woke the SoC from Low Power Mode.
> The wake up source IDs will be common for all K3 platforms.
>
> 2) TISCI_MSG_LPM_SET_DEVICE_CONSTRAINT
> Set LPM constraint on behalf of a device. By setting a constraint, the
> device ensures that it will not be powered off or reset in the selected
> mode.
>
> 3) TISCI_MSG_LPM_SET_LATENCY_CONSTRAINT
> Set LPM resume latency constraint. By setting a constraint, the host
> ensures that the resume time from selected mode will be less than the
> constraint value.
>
> [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> [g-vlaev@ti.com: LPM_WAKE_REASON and IO_ISOLATION support]
> Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
> [a-kaur@ti.com: SET_DEVICE_CONSTRAINT support]
> Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
> [vibhore@ti.com: SET_LATENCY_CONSTRAINT support]
> Signed-off-by: Vibhore Vardhan <vibhore@ti.com>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> Reviewed-by: Akashdeep Kaur <a-kaur@ti.com>
> Tested-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
> drivers/firmware/ti_sci.c | 198 +++++++++++++++++++++++++
> drivers/firmware/ti_sci.h | 76 ++++++++++
> include/linux/soc/ti/ti_sci_protocol.h | 26 ++++
> 3 files changed, 300 insertions(+)
>

<removing older email addresses from CC>

LGTM,
Acked-by: Dhruva Gole <d-gole@ti.com>

--
Best regards,
Dhruva Gole
Texas Instruments Incorporated