Re: [PATCH v3 08/12] arm64: dts: renesas: r9a08g045: Add RTC node

Alexandre Belloni
2024-10-16T22:03:49Z

On 11/10/2024 13:28:55+0300, claudiu beznea wrote:
> >> + compatible = "renesas,r9a08g045-rtca3", "renesas,rz-rtca3";
> >> + reg = <0 0x1004ec00 0 0x400>;
> >> + interrupts = <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> >> + interrupt-names = "alarm", "period", "carry";
> >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb VBATTB_VBATTCLK>;
> >> + clock-names = "bus", "counter";
> >> + assigned-clocks = <&vbattb VBATTB_MUX>;
> >> + assigned-clock-parents = <&vbattb VBATTB_XC>;
> >
> > Don't the assigned-clock* properties belong in the board DTS?
>
> It makes sense to be in the board DTS, indeed.
>
> > In addition, I think they should be documented in the DT bindings,
> > and be made required, so board developers don't forget about them.
>
> It would be better, indeed.

There were multiple recent emails from Rob saying that assigned-clocks
should not be part of the bindings.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering