public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	Perry Yuan <perry.yuan@amd.com>
Cc: linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
	AND 64-BIT)),
	linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING
	FRAMEWORK), Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 0/2] amd-pstate: Better handling for systems without an MSR
Date: Sun,  1 Sep 2024 00:00:33 -0500	[thread overview]
Message-ID: <20240901050035.1739935-1-superm1@kernel.org> (raw)

From: Mario Limonciello <mario.limonciello@amd.com>

Since the policy changed for amd-pstate to enable on systems
with shared memory designs by default too some users have
reported that software like power-profiles-daemon fails
with an error -524.

This happens because error codes from the CPPC API are ignored
during the initial setup so all the sysfs files are created but
don't work.

This series does two things:
1. Add a debugging early param to force going into shared memory mode
   even on a system with a dedicated MSR.  This will aid in debugging
   reported issues.
2. Catch errors in amd_pstate_epp_update_limit() and pass them up. If
   any errors occurred with CPPC API then amd-pstate won't be setup.

Mario Limonciello (2):
  cpufreq/amd-pstate: Add an early param to disable MSR mode
  cpufreq/amd-pstate: Catch failures for amd_pstate_epp_update_limit()

 .../admin-guide/kernel-parameters.txt         |  5 ++-
 Documentation/admin-guide/pm/amd-pstate.rst   |  5 +++
 drivers/cpufreq/amd-pstate.c                  | 43 +++++++++++++------
 3 files changed, 38 insertions(+), 15 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-09-01  5:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  5:00 Mario Limonciello [this message]
2024-09-01  5:00 ` [PATCH 1/2] cpufreq/amd-pstate: Add an early param to disable MSR mode Mario Limonciello
2024-09-03 13:14   ` Mario Limonciello
2024-09-01  5:00 ` [PATCH 2/2] cpufreq/amd-pstate: Catch failures for amd_pstate_epp_update_limit() Mario Limonciello
2024-09-02  9:24   ` Yuan, Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240901050035.1739935-1-superm1@kernel.org \
    --to=superm1@kernel.org \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perry.yuan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox