From: Andreas Herrmann <aherrmann@suse.de>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: x86@kernel.org, Andreas Herrmann <aherrmann@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Chen Yu <yu.c.chen@intel.com>, Len Brown <len.brown@intel.com>,
Radu Rendec <rrendec@redhat.com>,
Pierre Gondois <Pierre.Gondois@arm.com>, Pu Wen <puwen@hygon.cn>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Will Deacon <will@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Nikolay Borisov <nik.borisov@suse.com>,
Huang Ying <ying.huang@intel.com>,
Ricardo Neri <ricardo.neri@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] cacheinfo: Check for null last-level cache info
Date: Sun, 1 Sep 2024 20:07:19 +0200 [thread overview]
Message-ID: <20240901180719.GA4089@alberich> (raw)
In-Reply-To: <20240827051635.9114-2-ricardo.neri-calderon@linux.intel.com>
On Mon, Aug 26, 2024 at 10:16:32PM -0700, Ricardo Neri wrote:
> Before determining the validity of the last-level cache info, ensure that
> it has been allocated. Simply checking for non-zero cache_leaves() is not
> sufficient, as some architectures (e.g., Intel processors) have non-zero
> cache_leaves() before allocation.
>
> Dereferencing NULL cacheinfo can occur in update_per_cpu_data_slice_size().
> This function iterates over all online CPUs. However, a CPU may have come
> online recently, but its cacheinfo may not have been allocated yet.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Reviewed-by: Andreas Herrmann <aherrmann@suse.de>
Tested-by: Andreas Herrmann <aherrmann@suse.de>
Test was done with a system equipped with AMD Phenom II X6 1055T and
test kernels based on v6.11-rc5-176-g20371ba12063.
Thanks,
Andreas
next prev parent reply other threads:[~2024-09-01 18:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 5:16 [PATCH v5 0/4] x86/cacheinfo: Set the number of leaves per CPU Ricardo Neri
2024-08-27 5:16 ` [PATCH v5 1/4] cacheinfo: Check for null last-level cache info Ricardo Neri
2024-09-01 18:07 ` Andreas Herrmann [this message]
2024-08-27 5:16 ` [PATCH v5 2/4] cacheinfo: Allocate memory for memory if not done from the primary CPU Ricardo Neri
2024-08-28 13:16 ` Nikolay Borisov
2024-08-28 13:57 ` Sudeep Holla
2024-08-29 4:37 ` Ricardo Neri
2024-09-01 18:08 ` Andreas Herrmann
2024-08-27 5:16 ` [PATCH v5 3/4] x86/cacheinfo: Delete global num_cache_leaves Ricardo Neri
2024-08-28 12:57 ` Nikolay Borisov
2024-08-29 4:33 ` Ricardo Neri
2024-09-01 18:08 ` Andreas Herrmann
2024-08-27 5:16 ` [PATCH v5 4/4] x86/cacheinfo: Clean out init_cache_level() Ricardo Neri
2024-08-28 14:01 ` Nikolay Borisov
2024-08-29 4:38 ` Ricardo Neri
2024-09-01 18:09 ` Andreas Herrmann
2024-09-02 7:41 ` Andreas Herrmann
2024-09-04 7:30 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240901180719.GA4089@alberich \
--to=aherrmann@suse.de \
--cc=Pierre.Gondois@arm.com \
--cc=aherrmann@suse.com \
--cc=catalin.marinas@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=puwen@hygon.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=rrendec@redhat.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox