From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB91217B50B for ; Sun, 1 Sep 2024 18:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725214123; cv=none; b=t95oehlcEqWEnQBjxWH8xVZr0RjeG3MBk9K/VFgnmR3stEenDJls2J891AZqQxz1USiw/amBHXyiTfvyprhZoongS1oals73CoRIt/UB3asQOT5I0q4tdSyVQ/Y0ewXPdrht1799w8S99zD+OQtbK2rWJQHRNp2Osej6jAlVdUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725214123; c=relaxed/simple; bh=l/DscAc6cYYodCaK24DuuBIlCuEz9gQJBJI+fydlwEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SgzXiYFd1oN736yfvin78QfiQizCXS0mOz3FfXSeXHEXuSaIIBAf33yjwjPgQlWF4wD8YTvAmYDEXfPtOOwZfLUUtrttgaiQzoFf4L8eZOBR7Xw708zV5oel6VcY55xj2CuZXdFKt989MI6kqrSGVv5vMFAfqvpcudHZzOge2wQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rKztV13G; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=/o5hJTLj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rKztV13G; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=/o5hJTLj; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rKztV13G"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/o5hJTLj"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rKztV13G"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/o5hJTLj" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 305EA21B0E; Sun, 1 Sep 2024 18:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725214120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXvhVwXL6q1VPAGcxfLTeiywV9hLbQpFABx3PsM7Smg=; b=rKztV13GlzK8NzP5goehMFsPIFg+Hc8PcYYM1rY6l3R4XGTOlSt8H+bbvtJ0IpiOrd/eyu dhMnSxsZ1u5iv+sOmoBC4fyUM9258+SDi3fO98XhddzANc9ON5pBnzcCnh8ik9ta2IfKqH 7megWyAdqzMFJk2NmK0Be+sE2HJtkO8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725214120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXvhVwXL6q1VPAGcxfLTeiywV9hLbQpFABx3PsM7Smg=; b=/o5hJTLjwL/0dsVF5riGuaM/Hy240GzlYssktZZcepZkKwDrAuFdP9S/cEvorZbn5DEGXn kT3jvjUWlb4ySSAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725214120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXvhVwXL6q1VPAGcxfLTeiywV9hLbQpFABx3PsM7Smg=; b=rKztV13GlzK8NzP5goehMFsPIFg+Hc8PcYYM1rY6l3R4XGTOlSt8H+bbvtJ0IpiOrd/eyu dhMnSxsZ1u5iv+sOmoBC4fyUM9258+SDi3fO98XhddzANc9ON5pBnzcCnh8ik9ta2IfKqH 7megWyAdqzMFJk2NmK0Be+sE2HJtkO8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725214120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXvhVwXL6q1VPAGcxfLTeiywV9hLbQpFABx3PsM7Smg=; b=/o5hJTLjwL/0dsVF5riGuaM/Hy240GzlYssktZZcepZkKwDrAuFdP9S/cEvorZbn5DEGXn kT3jvjUWlb4ySSAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A4E4D1373A; Sun, 1 Sep 2024 18:08:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XubQJqet1GbnXwAAD6G6ig (envelope-from ); Sun, 01 Sep 2024 18:08:39 +0000 Date: Sun, 1 Sep 2024 20:08:38 +0200 From: Andreas Herrmann To: Ricardo Neri Cc: x86@kernel.org, Andreas Herrmann , Catalin Marinas , Chen Yu , Len Brown , Radu Rendec , Pierre Gondois , Pu Wen , "Rafael J. Wysocki" , Sudeep Holla , Srinivas Pandruvada , Will Deacon , Zhang Rui , Nikolay Borisov , Huang Ying , Ricardo Neri , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] x86/cacheinfo: Delete global num_cache_leaves Message-ID: <20240901180838.GC4089@alberich> References: <20240827051635.9114-1-ricardo.neri-calderon@linux.intel.com> <20240827051635.9114-4-ricardo.neri-calderon@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240827051635.9114-4-ricardo.neri-calderon@linux.intel.com> X-Spam-Score: -3.80 X-Spamd-Result: default: False [-3.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[18]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo,intel.com:email] X-Spam-Flag: NO X-Spam-Level: On Mon, Aug 26, 2024 at 10:16:34PM -0700, Ricardo Neri wrote: > Linux remembers cpu_cachinfo::num_leaves per CPU, but x86 initializes all > CPUs from the same global "num_cache_leaves". > > This is erroneous on systems such as Meteor Lake, where each CPU has a > distinct num_leaves value. Delete the global "num_cache_leaves" and > initialize num_leaves on each CPU. > > Reviewed-by: Len Brown > Signed-off-by: Ricardo Neri Reviewed-by: Andreas Herrmann Tested-by: Andreas Herrmann Test was done with a system equipped with AMD Phenom II X6 1055T and test kernels based on v6.11-rc5-176-g20371ba12063. Thanks, Andreas