From: Jakub Kicinski <kuba@kernel.org>
To: Wan Junjie <junjie.wan@inceptio.ai>
Cc: horms@kernel.org, davem@davemloft.net, edumazet@google.com,
ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v2] dpaa2-switch: fix flooding domain among multiple vlans
Date: Mon, 2 Sep 2024 18:37:23 -0700 [thread overview]
Message-ID: <20240902183723.0dd4d192@kernel.org> (raw)
In-Reply-To: <20240902124318.263883-1-junjie.wan@inceptio.ai>
On Mon, 2 Sep 2024 20:43:18 +0800 Wan Junjie wrote:
> > > -static u16 dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv)
> > > +static u16 dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv, u16 vid)
> >
> > This, and several other lines in this patch, could be trivially
> > line wrapped in order for them to be <= 80 columns wide, as is
> > still preferred in Networking code.
> >
> > This and a number of other minor problems are flagged by:
> > ./scripts/checkpatch.pl --strict --codespell --max-line-length=80
>
> It is hard to keep all lines limited to the length of 80 since some function
> names are really long. I have tried to make the line length to 85 without
> breaking some if conditions into multiple lines. You will see in v3.
FWIW it's relatively common to break the line after return type:
static u16
dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv, u16 vid)
next prev parent reply other threads:[~2024-09-03 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 1:50 [PATCH v2] dpaa2-switch: fix flooding domain among multiple vlans Wan Junjie
2024-09-02 10:57 ` Simon Horman
2024-09-02 12:43 ` Wan Junjie
2024-09-03 1:37 ` Jakub Kicinski [this message]
2024-09-02 14:07 ` Ioana Ciornei
2024-09-04 16:03 ` Ioana Ciornei
2024-09-05 6:15 ` junjie.wan
2024-09-06 9:57 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902183723.0dd4d192@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=junjie.wan@inceptio.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox