* [PATCH -next] drm/msm: Remove unneeded semicolon
@ 2024-09-03 0:56 Yang Li
2024-09-16 22:33 ` Abhinav Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-09-03 0:56 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, airlied
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Yang Li,
Abaci Robot
./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
index 0e3a2b16a2ce..65cf237c6b4e 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
@@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
case 25:
found_hsclk_divsel = 14;
break;
- };
+ }
pd->vco_freq = found_vco_freq;
pd->tx_band_sel = found_tx_band_sel;
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/msm: Remove unneeded semicolon
2024-09-03 0:56 [PATCH -next] drm/msm: Remove unneeded semicolon Yang Li
@ 2024-09-16 22:33 ` Abhinav Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Abhinav Kumar @ 2024-09-16 22:33 UTC (permalink / raw)
To: Yang Li, robdclark, dmitry.baryshkov, airlied
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Abaci Robot
On 9/2/2024 5:56 PM, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Change looks fine but can you pls have a short one line in the commit
text instead of just pasting the error from the errorchecker?
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> index 0e3a2b16a2ce..65cf237c6b4e 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> @@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
> case 25:
> found_hsclk_divsel = 14;
> break;
> - };
> + }
>
> pd->vco_freq = found_vco_freq;
> pd->tx_band_sel = found_tx_band_sel;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-16 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 0:56 [PATCH -next] drm/msm: Remove unneeded semicolon Yang Li
2024-09-16 22:33 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox