From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Constify struct intel_pinctrl parameter
Date: Tue, 3 Sep 2024 07:57:06 +0300 [thread overview]
Message-ID: <20240903045706.GY1532424@black.fi.intel.com> (raw)
In-Reply-To: <20240902141607.2694988-1-andriy.shevchenko@linux.intel.com>
On Mon, Sep 02, 2024 at 05:15:11PM +0300, Andy Shevchenko wrote:
> -static void __iomem *intel_get_padcfg(struct intel_pinctrl *pctrl,
> +static void __iomem *intel_get_padcfg(const struct intel_pinctrl *pctrl,
> unsigned int pin, unsigned int reg)
This is not good. You take const pointer but return non-const inside
that struct. I don't think we should "change" the constness this way.
All changes that take const pointer and return scalar are fine, though
(did not check all of them).
next prev parent reply other threads:[~2024-09-03 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:15 [PATCH v1 1/1] pinctrl: intel: Constify struct intel_pinctrl parameter Andy Shevchenko
2024-09-03 4:57 ` Mika Westerberg [this message]
2024-09-03 11:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903045706.GY1532424@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox