From: Greg KH <gregkh@linuxfoundation.org>
To: srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 4/9] nvmem: layouts: add U-Boot env layout
Date: Tue, 3 Sep 2024 12:12:56 +0200 [thread overview]
Message-ID: <2024090308-smasher-craftwork-0db5@gregkh> (raw)
In-Reply-To: <20240902142952.71639-5-srinivas.kandagatla@linaro.org>
On Mon, Sep 02, 2024 at 03:29:47PM +0100, srinivas.kandagatla@linaro.org wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> U-Boot environment variables are stored in a specific format. Actual
> data can be placed in various storage sources (MTD, UBI volume, EEPROM,
> NVRAM, etc.).
>
> Move all generic (NVMEM device independent) code from NVMEM device
> driver to an NVMEM layout driver. Then add a simple NVMEM layout code on
> top of it.
>
> This allows using NVMEM layout for parsing U-Boot env data stored in any
> kind of NVMEM device.
>
> The old NVMEM glue driver stays in place for handling bindings in the
> MTD context. To avoid code duplication it uses exported layout parsing
> function. Please note that handling MTD & NVMEM layout bindings may be
> refactored in the future.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> MAINTAINERS | 1 +
> drivers/nvmem/Kconfig | 3 +-
> drivers/nvmem/layouts/Kconfig | 11 ++
> drivers/nvmem/layouts/Makefile | 1 +
> drivers/nvmem/layouts/u-boot-env.c | 211 +++++++++++++++++++++++++++++
> drivers/nvmem/layouts/u-boot-env.h | 15 ++
> drivers/nvmem/u-boot-env.c | 165 +---------------------
> 7 files changed, 242 insertions(+), 165 deletions(-)
> create mode 100644 drivers/nvmem/layouts/u-boot-env.c
> create mode 100644 drivers/nvmem/layouts/u-boot-env.h
This patch doesn't apply to my tree :(
Also, if you generate patches with 'git format-patch -M' you can see
when files move easier (if that's what happened here, hard to tell..)
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-03 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:29 [PATCH 0/9] nvmem: patches(set 1) for 6.12 srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 1/9] dt-bindings: nvmem: imx-ocotp: support i.MX95 srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 2/9] nvmem: imx-ocotp-ele: " srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 3/9] dt-bindings: nvmem: convert U-Boot env to a layout srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 4/9] nvmem: layouts: add U-Boot env layout srinivas.kandagatla
2024-09-03 10:12 ` Greg KH [this message]
2024-09-03 10:55 ` Srinivas Kandagatla
2024-09-03 11:04 ` Rafał Miłecki
2024-09-03 11:24 ` Greg KH
2024-09-10 13:24 ` Rafał Miłecki
2024-09-11 14:06 ` Greg KH
2024-09-02 14:29 ` [PATCH 5/9] MAINTAINERS: Update path for U-Boot environment variables YAML srinivas.kandagatla
2024-09-03 10:13 ` Greg KH
2024-09-02 14:29 ` [PATCH 6/9] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 7/9] nvmem: sunplus-ocotp: Use devm_platform_ioremap_resource_byname() helper function srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 8/9] nvmem: Fix misspelling srinivas.kandagatla
2024-09-02 14:29 ` [PATCH 9/9] dt-bindings: nvmem: sfp: add ref to nvmem-deprecated-cells.yaml srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090308-smasher-craftwork-0db5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox