From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4FE61CA6A2 for ; Tue, 3 Sep 2024 12:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725367596; cv=none; b=Lud5QyiBKMeBHWSMFk6d4FEeDNThBCi8m3g6OIFEiAjAXMZk8uCuAN2dNwpkNtRipaN7O8t7dNJiRZ1zNRBEzYJTdA4OxFHKovyfRHzHVwHppVn1FST0DbILJGWHrO0JI8cdXlJ/ESVstmbsiwr2uUjeiKPAtmL7i1EZUfhF54o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725367596; c=relaxed/simple; bh=Rlyxtlo5hzI9N3YYU1nTTHUB+oS3mO6LVjK+srmICQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qZgym4+gvLjWSneFtJZ9pNQzYGnDWEUzuAgz/wUAUsGaPYwOvY07bDfSvyO9YpKP+a9S15fx0NGmJkv5hXjPgH+FtDjZy4Y0AW3DKIysJxq33vq7/c/YvVNWmA1m/CsRYtFnmYF8ofrzWYGuBMCzP+kbcBEas2+yFFwOVpeTEbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VZtMPNpa; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VZtMPNpa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725367593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ixgiDmvar1tWfYl+K7VyNawCctRA3Ge+tCMoawRgM90=; b=VZtMPNpavK7qBqLA/Phs3iiYDUJfm8HlBq4loR+hYn2xiR5Umv1pyouHafAy1Xi7e65jtk Ad4MKwUKWgl6qB02XyH4hyjXdpq6o/jPqsLQcbq/llk28stGQlMSp2HnVUqeNgFhnfo4KV QNbve75Ynx1bx9w5BMjU54EIexlqOng= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-Ows8vTQyP96DVRLqnAUn_A-1; Tue, 03 Sep 2024 08:46:29 -0400 X-MC-Unique: Ows8vTQyP96DVRLqnAUn_A-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F9F519560B4; Tue, 3 Sep 2024 12:46:24 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.38]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id DE32D1955DD8; Tue, 3 Sep 2024 12:46:18 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 3 Sep 2024 14:46:14 +0200 (CEST) Date: Tue, 3 Sep 2024 14:46:07 +0200 From: Oleg Nesterov To: Sven Schnelle Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Masami Hiramatsu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] uprobes: use kzalloc to allocate xol area Message-ID: <20240903124607.GB17936@redhat.com> References: <20240903102313.3402529-1-svens@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903102313.3402529-1-svens@linux.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 On 09/03, Sven Schnelle wrote: > > To prevent unitialized members, use kzalloc to allocate > the xol area. > > Signed-off-by: Sven Schnelle Acked-by: Oleg Nesterov and since this looks easily exploitable, I'd sugest Cc: stable@vger.kernel.org Fixes: b059a453b1cf1 ("x86/vdso: Add mremap hook to vm_special_mapping") > --- > kernel/events/uprobes.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 73cc47708679..50d7949be2b1 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -1489,7 +1489,7 @@ static struct xol_area *__create_xol_area(unsigned long vaddr) > struct xol_area *area; > void *insns; > > - area = kmalloc(sizeof(*area), GFP_KERNEL); > + area = kzalloc(sizeof(*area), GFP_KERNEL); > if (unlikely(!area)) > goto out; > > @@ -1499,7 +1499,6 @@ static struct xol_area *__create_xol_area(unsigned long vaddr) > goto free_area; > > area->xol_mapping.name = "[uprobes]"; > - area->xol_mapping.fault = NULL; > area->xol_mapping.pages = area->pages; > area->pages[0] = alloc_page(GFP_HIGHUSER); > if (!area->pages[0]) > -- > 2.43.0 >