public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Shuah Khan <shuah@kernel.org>,
	Reinette Chatre <reinette.chatre@intel.com>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
	"Fenghua Yu" <fenghua.yu@intel.com>,
	"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 3/4] selftests/x86: don't clobber CFLAGS
Date: Tue,  3 Sep 2024 17:45:27 +0300	[thread overview]
Message-ID: <20240903144528.46811-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20240903144528.46811-1-ilpo.jarvinen@linux.intel.com>

The x86 selftests makefile clobbers CFLAGS preventing lib.mk from
making the necessary adjustments into CFLAGS. This would lead to a
build failure after upcoming change which wants to add -DHAVE_CPUID=
into CFLAGS.

Reorder CFLAGS initialization in x86 selftest. Place the constant part
of CFLAGS initialization before inclusion of lib.mk but leave adding
KHDR_INCLUDES into CFLAGS into the existing position because
KHDR_INCLUDES might be generated inside lib.mk.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
v4:
- New patch

 tools/testing/selftests/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 5c8757a25998..88a6576de92f 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -1,4 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
+CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
+
 all:
 
 include ../lib.mk
@@ -35,7 +37,7 @@ BINARIES_64 := $(TARGETS_C_64BIT_ALL:%=%_64)
 BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))
 BINARIES_64 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_64))
 
-CFLAGS := -O2 -g -std=gnu99 -pthread -Wall $(KHDR_INCLUDES)
+CFLAGS += $(KHDR_INCLUDES)
 
 # call32_from_64 in thunks.S uses absolute addresses.
 ifeq ($(CAN_BUILD_WITH_NOPIE),1)
-- 
2.39.2


  parent reply	other threads:[~2024-09-03 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 14:45 [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues Ilpo Järvinen
2024-09-03 14:45 ` [PATCH v4 1/4] selftests/resctrl: Generalize non-contiguous CAT check Ilpo Järvinen
2024-09-03 14:45 ` [PATCH v4 2/4] selftests/resctrl: Always initialize ecx to avoid build warnings Ilpo Järvinen
2024-09-03 14:45 ` Ilpo Järvinen [this message]
2024-09-03 18:22   ` [PATCH v4 3/4] selftests/x86: don't clobber CFLAGS Reinette Chatre
2024-09-04 13:17     ` Ilpo Järvinen
2024-09-03 14:45 ` [PATCH v4 4/4] kselftest: Provide __cpuid_count() stub on non-x86 archs Ilpo Järvinen
2024-09-03 23:18 ` [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues Shuah Khan
2024-09-04 12:18   ` Ilpo Järvinen
2024-09-04 12:30     ` Shuah Khan
2024-09-04 12:54       ` Ilpo Järvinen
2024-09-05 18:06         ` Shuah Khan
2024-09-05 20:43           ` Reinette Chatre
2024-09-05 20:51             ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903144528.46811-4-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@jp.fujitsu.com \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox