* [PATCH] mkfs.f2fs: use correct endian conversion for writing lpf inode
@ 2024-09-03 17:31 Daeho Jeong
2024-09-05 1:14 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Daeho Jeong @ 2024-09-03 17:31 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
From: Daeho Jeong <daehojeong@google.com>
The conversion between cpu and little endian is incorrect.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
mkfs/f2fs_format.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index c9d335a..30d8e19 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -1547,8 +1547,8 @@ static int f2fs_write_lpf_inode(void)
f2fs_init_inode(sb, raw_node, c.lpf_ino, mkfs_time, 0x41c0);
- raw_node->i.i_pino = le32_to_cpu(sb->root_ino);
- raw_node->i.i_namelen = le32_to_cpu(strlen(LPF));
+ raw_node->i.i_pino = sb->root_ino;
+ raw_node->i.i_namelen = cpu_to_le32(strlen(LPF));
memcpy(raw_node->i.i_name, LPF, strlen(LPF));
node_blkaddr = alloc_next_free_block(CURSEG_HOT_NODE);
--
2.46.0.469.g59c65b2a67-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] mkfs.f2fs: use correct endian conversion for writing lpf inode
2024-09-03 17:31 [PATCH] mkfs.f2fs: use correct endian conversion for writing lpf inode Daeho Jeong
@ 2024-09-05 1:14 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2024-09-05 1:14 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
On 2024/9/4 1:31, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> The conversion between cpu and little endian is incorrect.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-05 1:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 17:31 [PATCH] mkfs.f2fs: use correct endian conversion for writing lpf inode Daeho Jeong
2024-09-05 1:14 ` [f2fs-dev] " Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox