From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001E41D7992; Tue, 3 Sep 2024 20:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725396183; cv=none; b=lYA6+/Z/NMNaifq3C3XmpMXUno1FmKiGpkSK96luxwMOQtP3E4mxgqplT8pDUTCout9F2p+hqV/NPHLM64ErmY7sFd26weah7P+xLip8cY2b128HV+Ga25HzinyxyBxOw/GoXg2KhMHIefvBopAJmJoMBOytq52IUeM9IZWVMU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725396183; c=relaxed/simple; bh=5nbZndPC7lyxS7bm1KHdpcOZElcnrBptWJd0X0QyvqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hEQWpznv+tXgHq3mEGqeS47Q94p2WwAufLyIw2pToGnDtC0N0MTUNDSUdY3yShanbPCsaQAxq2D0wkJRdqpgwpXV0VL47+IVv+cJJXae9B3vAI8/lIKu2JNb5bg05ObHiBZYmP+a4ARL8WSQAeFXpTkL2jxVCfyHH0P+yeTd4k0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jn3XWytj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jn3XWytj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AF67C4CEC4; Tue, 3 Sep 2024 20:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725396182; bh=5nbZndPC7lyxS7bm1KHdpcOZElcnrBptWJd0X0QyvqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jn3XWytjcIczt7OS8MbbHi+m6fRAwUdH2DeThTb7n5nntUynflIn+jgxMFHG1+oB+ bcPQ3wOrqX2xJmzICPnQvP7spnqRr3LvNNgtQCptITGZ2ARjLA/DhnBu0ClhIOwWDe Jkfr2lo7QLXorpPraQXWj25S7bbDCxf8eX2BAUvWz8d1dSH9wCT6Vv4J/zw9GOV9Lf w6rNIOaVkMPntbvIvGXiAYdmkebDwfQt/RlWJQ5l2aWulNVkcuQPnbfF4oazWODTjz maCbUfi/DmJFgpOaMz2Ly98wCHD/hQm/9FFEDeAR1e4fOKKfnklBXvhB+Q7nR06mHN 3xmMvs/4RjF5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Emmanuel Grumbach , Miri Korenblit , Johannes Berg , Sasha Levin , kvalo@kernel.org, gregory.greenman@intel.com, daniel.gabay@intel.com, justinstitt@google.com, yedidya.ben.shimol@intel.com, linux-wireless@vger.kernel.org Subject: [PATCH AUTOSEL 6.10 22/22] wifi: iwlwifi: clear trans->state earlier upon error Date: Tue, 3 Sep 2024 15:22:09 -0400 Message-ID: <20240903192243.1107016-22-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240903192243.1107016-1-sashal@kernel.org> References: <20240903192243.1107016-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.7 Content-Transfer-Encoding: 8bit From: Emmanuel Grumbach [ Upstream commit 094513f8a2fbddee51b055d8035f995551f98fce ] When the firmware crashes, we first told the op_mode and only then, changed the transport's state. This is a problem if the op_mode's nic_error() handler needs to send a host command: it'll see that the transport's state still reflects that the firmware is alive. Today, this has no consequences since we set the STATUS_FW_ERROR bit and that will prevent sending host commands. iwl_fw_dbg_stop_restart_recording looks at this bit to know not to send a host command for example. To fix the hibernation, we needed to reset the firmware without having an error and checking STATUS_FW_ERROR to see whether the firmware is alive will no longer hold, so this change is necessary as well. Change the flow a bit. Change trans->state before calling the op_mode's nic_error() method and check trans->state instead of STATUS_FW_ERROR. This will keep the current behavior of iwl_fw_dbg_stop_restart_recording upon firmware error, and it'll allow us to call iwl_fw_dbg_stop_restart_recording safely even if STATUS_FW_ERROR is clear, but yet, the firmware is not alive. Signed-off-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit Link: https://patch.msgid.link/20240825191257.9d7427fbdfd7.Ia056ca57029a382c921d6f7b6a6b28fc480f2f22@changeid [I missed this was a dependency for the hibernation fix, changed the commit message a bit accordingly] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 945ffc083d25c..79fffa82cfd92 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -3352,7 +3352,7 @@ void iwl_fw_dbg_stop_restart_recording(struct iwl_fw_runtime *fwrt, { int ret __maybe_unused = 0; - if (test_bit(STATUS_FW_ERROR, &fwrt->trans->status)) + if (!iwl_trans_fw_running(fwrt->trans)) return; if (fw_has_capa(&fwrt->fw->ucode_capa, diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h index b93cef7b23301..4c56dccb18a9b 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h @@ -1579,8 +1579,8 @@ static inline void iwl_trans_fw_error(struct iwl_trans *trans, bool sync) /* prevent double restarts due to the same erroneous FW */ if (!test_and_set_bit(STATUS_FW_ERROR, &trans->status)) { - iwl_op_mode_nic_error(trans->op_mode, sync); trans->state = IWL_TRANS_NO_FW; + iwl_op_mode_nic_error(trans->op_mode, sync); } } -- 2.43.0