From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9551E8B85; Tue, 3 Sep 2024 20:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725396460; cv=none; b=dvv7BaLR3u4Cbf9Ek2P4xKfXQ9+l3zwFjeutyym9+RXGd8FBkmk3cg15UAEx548Q26PQXpVO5U7X4r1rIAGWuDBDc3alCKUTXpXIZH20PJBtdl7IiE3Exv0AZwMaLiMDxK50eQNitPsrEolekmguVgdAGOhqxrz6ej2E9HOvvkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725396460; c=relaxed/simple; bh=3/RiCuXHyqKlE5D6r1gR+oVpRb8jRcOBXFnW40NedQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XSO1xkfllpZZp6PhAWpwhZ+mzO84MvYnETc3QxsDqC6wniR1aJGUBtdAmKVvly7d386fVJWr0HJ+u1f6xyCHM0XaPmNxs18XJLNEwMK6RjninepmH2bDqFhkNAPeHq3kneDcaAyjnnvChaQf9xd5I7SF/6rg1CN5OT4wGdD52Mo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ImRNj2J4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ImRNj2J4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18259C4CEC5; Tue, 3 Sep 2024 20:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725396459; bh=3/RiCuXHyqKlE5D6r1gR+oVpRb8jRcOBXFnW40NedQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ImRNj2J4r/jWT5NEEG+cGADR+1lIqGhd3lAIINSDxigi67ciKnyDv2qpfe066Rshs Wf0wgHnskWGagRKtxloyUguexAjBe6Qa7VR/umGFJXpH5KUXvnGVYhKd5AsNPsPwtK paXQUs5zWTq1JPxXqoij9CV/iuUee/ptr1VQ9cmWdveT+sejv1+7VoosU9pxT17LVG KUDzyqGJDo1xQbph3SxewNQ2W6Glt2M6qEaN12ojUACzhmjnvUiWoiYSl9TKJ/LcHj TgQP4D8QkjdxZSfiorc5vXeuZ86rc2BmWYen45IcZpA3xZESS++GWleoKbII+osAR9 fd4RKRsi595gA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kailang Yang , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, sbinding@opensource.cirrus.com, simont@opensource.cirrus.com, foss@athaariq.my.id, rf@opensource.cirrus.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 3/8] ALSA: hda/realtek - FIxed ALC285 headphone no sound Date: Tue, 3 Sep 2024 15:27:53 -0400 Message-ID: <20240903192815.1108754-3-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240903192815.1108754-1-sashal@kernel.org> References: <20240903192815.1108754-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.224 Content-Transfer-Encoding: 8bit From: Kailang Yang [ Upstream commit 1fa7b099d60ad64f559bd3b8e3f0d94b2e015514 ] Dell platform with ALC215 ALC285 ALC289 ALC225 ALC295 ALC299, plug headphone or headset. It had a chance to get no sound from headphone. Replace depop procedure will solve this issue. Signed-off-by: Kailang Yang Link: https://lore.kernel.org/d0de1b03fd174520945dde216d765223@realtek.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_realtek.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 269e973dde3e8..190d21fd83576 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5007,6 +5007,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec) case 0x10ec0295: case 0x10ec0289: case 0x10ec0299: + alc_hp_mute_disable(codec, 75); alc_process_coef_fw(codec, alc225_pre_hsmode); alc_process_coef_fw(codec, coef0225); break; @@ -5232,6 +5233,7 @@ static void alc_headset_mode_default(struct hda_codec *codec) case 0x10ec0299: alc_process_coef_fw(codec, alc225_pre_hsmode); alc_process_coef_fw(codec, coef0225); + alc_hp_enable_unmute(codec, 75); break; case 0x10ec0255: alc_process_coef_fw(codec, coef0255); @@ -5391,6 +5393,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec) alc_process_coef_fw(codec, coef0225_2); else alc_process_coef_fw(codec, coef0225_1); + alc_hp_enable_unmute(codec, 75); break; case 0x10ec0867: alc_update_coefex_idx(codec, 0x57, 0x5, 1<<14, 0); @@ -5496,6 +5499,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec) case 0x10ec0289: case 0x10ec0299: alc_process_coef_fw(codec, coef0225); + alc_hp_enable_unmute(codec, 75); break; } codec_dbg(codec, "Headset jack set to Nokia-style headset mode.\n"); @@ -5655,12 +5659,6 @@ static void alc_determine_headset_type(struct hda_codec *codec) case 0x10ec0295: case 0x10ec0289: case 0x10ec0299: - snd_hda_codec_write(codec, 0x21, 0, - AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE); - msleep(80); - snd_hda_codec_write(codec, 0x21, 0, - AC_VERB_SET_PIN_WIDGET_CONTROL, 0x0); - alc_process_coef_fw(codec, alc225_pre_hsmode); alc_update_coef_idx(codec, 0x67, 0xf000, 0x1000); val = alc_read_coef_idx(codec, 0x45); @@ -5677,15 +5675,19 @@ static void alc_determine_headset_type(struct hda_codec *codec) val = alc_read_coef_idx(codec, 0x46); is_ctia = (val & 0x00f0) == 0x00f0; } + if (!is_ctia) { + alc_update_coef_idx(codec, 0x45, 0x3f<<10, 0x38<<10); + alc_update_coef_idx(codec, 0x49, 3<<8, 1<<8); + msleep(100); + val = alc_read_coef_idx(codec, 0x46); + if ((val & 0x00f0) == 0x00f0) + is_ctia = false; + else + is_ctia = true; + } alc_update_coef_idx(codec, 0x4a, 7<<6, 7<<6); alc_update_coef_idx(codec, 0x4a, 3<<4, 3<<4); alc_update_coef_idx(codec, 0x67, 0xf000, 0x3000); - - snd_hda_codec_write(codec, 0x21, 0, - AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT); - msleep(80); - snd_hda_codec_write(codec, 0x21, 0, - AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); break; case 0x10ec0867: is_ctia = true; -- 2.43.0