Re: [PATCH v9] usb: gadget: u_serial: Add null pointer check in gs_read_complete & gs_write_complete

gregkh
2024-09-03T06:26:18Z

On Thu, Aug 29, 2024 at 11:54:39AM +0000, 胡连勤 wrote:
> From: Lianqin Hu <hulianqin@vivo.com>
>
> Considering that in some extreme cases, when the unbind operation
> is being executed, gserial_disconnect has already cleared gser->ioport,
> triggering a gadget reconfiguration at this time and gs_read_complete
> gets called afterwards, which results in accessing null pointer,
> add a null pointer check to prevent this situation.
>
> Added a static spinlock to prevent gser->ioport from becoming
> null after the newly added check.

In looking at this further, shouldn't we just be moving around where we
call usb_ep_disable() in gserial_disconnect()?

Can't we shut down the endpoints _BEFORE_ we set the port structures to
NULL? After the endpoints are stopped, then we know that there is no
outstanding i/o possible and then we can clean up properly?

Not to say that your change doesn't fix the race condition here, but
cleaning up things in the proper order might be the better way as then
there can not be any race conditions at all?

Have you tried that?

thanks,

greg k-h