Re: [PATCH] longsoon/percpu: Simplify _percpu_read() and _percpu_write()

Uros Bizjak
2024-09-03T19:01:22Z

On Tue, Sep 3, 2024 at 8:57 PM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Tue, 2024-09-03 at 12:23 +0200, Uros Bizjak wrote:
> > +#define _percpu_write(size, _pcp, _val) \
> > +do { \
> > + unsigned long __pcp_val = __pcpu_cast_##size(_val); \
> > + \
> > + __asm__ __volatile__ (__pcpu_op_##size("stx") "%[val] $r21, %[ptr] \n" \
>
> Missing a comma before $r21 (as the bot already pointed out).

Oh, indeed... I triple checked the patch and missed the most obvious thing :(

BR,
Uros.

>
> > + : \
> > + : [val] "r"(__pcp_val), [ptr] "r"(&(_pcp)) \
> > + : "memory"); \
> > +} while (0)
>
> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University