Re: [PATCH] longsoon/percpu: Simplify _percpu_read() and _percpu_write()

kernel test robot
2024-09-03T21:36:36Z

Hi Uros,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dennis-percpu/for-next]
[also build test WARNING on linus/master v6.11-rc6 next-20240903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Uros-Bizjak/longsoon-percpu-Simplify-_percpu_read-and-_percpu_write/20240903-182524
base: https://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu.git for-next
patch link: https://lore.kernel.org/r/20240903102342.36957-1-ubizjak%40gmail.com
patch subject: [PATCH] longsoon/percpu: Simplify _percpu_read() and _percpu_write()
config: loongarch-loongson3_defconfig (https://download.01.org/0day-ci/archive/20240904/202409040542.OSJFk9k7-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240904/202409040542.OSJFk9k7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409040542.OSJFk9k7-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/sched.h:2134,
from arch/loongarch/kernel/asm-offsets.c:8:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
--
In file included from include/linux/percpu.h:13,
from include/linux/context_tracking_state.h:5,
from include/linux/hardirq.h:5,
from include/linux/interrupt.h:11,
from kernel/panic.c:14:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
kernel/panic.c: In function '__warn':
kernel/panic.c:670:17: warning: function '__warn' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
670 | vprintk(args->fmt, args->args);
| ^~~~~~~
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/sched.h:2134,
from include/linux/sched/mm.h:7,
from kernel/cpu.c:6:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
{standard input}: Assembler messages:
{standard input}:5077: Error: no match insn: stx.w $r14 $r21,$r12
{standard input}:5084: Error: no match insn: stx.w $r14 $r21,$r12
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/mm.h:7,
from kernel/audit.c:38:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1979:9: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1979 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1988:17: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1988 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:16,
from kernel/relay.c:17:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
kernel/relay.c: In function 'relay_create_buf_file':
kernel/relay.c:357:42: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
357 | snprintf(tmpname, NAME_MAX, "%s%d", chan->base_filename, cpu);
| ^
kernel/relay.c:357:9: note: 'snprintf' output between 2 and 266 bytes into a destination of size 255
357 | snprintf(tmpname, NAME_MAX, "%s%d", chan->base_filename, cpu);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/mm.h:7,
from mm/slub.c:13:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
mm/slub.c: In function 'put_partials':
arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
mm/slub.c:2937:9: note: in expansion of macro 'this_cpu_write'
2937 | this_cpu_write(s->cpu_slab->partial, NULL);
| ^~~~~~~~~~~~~~
mm/slub.c: In function 'put_cpu_partial':
arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct slab *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
mm/slub.c:2992:9: note: in expansion of macro 'this_cpu_write'
2992 | this_cpu_write(s->cpu_slab->partial, slab);
| ^~~~~~~~~~~~~~
{standard input}: Assembler messages:
{standard input}:8207: Error: no match insn: stx.d $r13 $r21,$r14
{standard input}:9031: Error: no match insn: stx.d $r15 $r21,$r13
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/wait.h:9,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/highmem.h:5,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/blkdev.h:9,
from mm/swapfile.c:9:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
{standard input}: Assembler messages:
{standard input}:1338: Error: no match insn: stx.w $r5 $r21,$r12
--
In file included from include/linux/irqflags.h:19,
from include/linux/spinlock.h:59,
from include/linux/sched.h:2134,
from include/linux/cgroup.h:12,
from include/linux/memcontrol.h:13,
from mm/memcontrol.c:29:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
{standard input}: Assembler messages:
{standard input}:5759: Error: no match insn: stx.d $r4 $r21,$r12
{standard input}:5781: Error: no match insn: stx.d $r25 $r21,$r12
--
In file included from include/linux/irqflags.h:19,
from include/linux/rcupdate.h:26,
from include/linux/rculist.h:11,
from include/linux/sched/signal.h:5,
from fs/buffer.c:23:
include/linux/sched/mm.h: In function 'set_active_memcg':
>> arch/loongarch/include/asm/percpu.h:85:33: warning: initialization of 'long unsigned int' from 'struct mem_cgroup *' makes integer from pointer without a cast [-Wint-conversion]
85 | #define __pcpu_cast_8(val) (val)
| ^
arch/loongarch/include/asm/percpu.h:89:35: note: in expansion of macro '__pcpu_cast_8'
89 | unsigned long __pcp_val = __pcpu_cast_##size(_val); \
| ^~~~~~~~~~~~
arch/loongarch/include/asm/percpu.h:171:36: note: in expansion of macro '_percpu_write'
171 | #define this_cpu_write_8(pcp, val) _percpu_write(8, pcp, val)
| ^~~~~~~~~~~~~
include/linux/percpu-defs.h:368:25: note: in expansion of macro 'this_cpu_write_8'
368 | case 8: stem##8(variable, __VA_ARGS__);break; \
| ^~~~
include/linux/percpu-defs.h:490:41: note: in expansion of macro '__pcpu_size_call'
490 | #define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
| ^~~~~~~~~~~~~~~~
include/linux/sched/mm.h:420:17: note: in expansion of macro 'this_cpu_write'
420 | this_cpu_write(int_active_memcg, memcg);
| ^~~~~~~~~~~~~~
{standard input}: Assembler messages:
{standard input}:1678: Error: no match insn: stx.d $r13 $r21,$r12
{standard input}:1733: Error: no match insn: stx.d $r28 $r21,$r12
..

vim +85 arch/loongarch/include/asm/percpu.h

81
82 #define __pcpu_cast_1(val) (((unsigned long) val) & 0xff)
83 #define __pcpu_cast_2(val) (((unsigned long) val) & 0xffff)
84 #define __pcpu_cast_4(val) (((unsigned long) val) & 0xffffffff)
> 85 #define __pcpu_cast_8(val) (val)
86