From: Peter Zijlstra <peterz@infradead.org>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Leonardo Bras <leobras@redhat.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Rik van Riel <riel@surriel.com>,
Thorsten Blum <thorsten.blum@toblux.com>,
Zqiang <qiang.zhang1211@gmail.com>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Caleb Sander Mateos <csander@purestorage.com>,
linux-kernel@vger.kernel.org,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Chen Yu <yu.c.chen@intel.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [RFC PATCH v2 4/5] softirq: Unify should_wakeup_ksoftirqd()
Date: Wed, 4 Sep 2024 14:15:13 +0200 [thread overview]
Message-ID: <20240904121513.GH4723@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240904111223.1035-5-kprateek.nayak@amd.com>
On Wed, Sep 04, 2024 at 11:12:22AM +0000, K Prateek Nayak wrote:
> @@ -118,14 +101,40 @@ EXPORT_PER_CPU_SYMBOL_GPL(hardirq_context);
> * the task which is in a softirq disabled section is preempted or blocks.
> */
> struct softirq_ctrl {
> +#ifdef CONFIG_PREEMPT_RT
> local_lock_t lock;
> +#endif
> int cnt;
> };
>
> -static DEFINE_PER_CPU(struct softirq_ctrl, softirq_ctrl) = {
> +static DEFINE_PER_CPU_ALIGNED(struct softirq_ctrl, softirq_ctrl) = {
> +#ifdef CONFIG_PREEMPT_RT
> .lock = INIT_LOCAL_LOCK(softirq_ctrl.lock),
> +#endif
> };
With the exception of CONFIG_DEBUG_LOCK_ALLOC (part of LOCKDEP)
local_lock_t is an empty structure when PREEMPT_RT=n.
That is to say, you can probably get by without those extra #ifdefs.
next prev parent reply other threads:[~2024-09-04 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:12 [RFC PATCH v2 0/5] Idle Load Balance fixes and softirq enhancements K Prateek Nayak
2024-09-04 11:12 ` [RFC PATCH v2 1/5] softirq: Allow raising SCHED_SOFTIRQ from SMP-call-function on RT kernel K Prateek Nayak
2024-09-04 11:12 ` [RFC PATCH v2 2/5] sched/core: Remove the unnecessary need_resched() check in nohz_csd_func() K Prateek Nayak
2024-09-04 11:12 ` [RFC PATCH v2 3/5] softirq: Mask reads of softirq_ctrl.cnt with SOFTIRQ_MASK for PREEMPT_RT K Prateek Nayak
2024-09-04 11:12 ` [RFC PATCH v2 4/5] softirq: Unify should_wakeup_ksoftirqd() K Prateek Nayak
2024-09-04 12:15 ` Peter Zijlstra [this message]
2024-09-04 13:40 ` K Prateek Nayak
2024-09-04 11:12 ` [RFC PATCH v2 5/5] softirq: Avoid unnecessary wakeup of ksoftirqd when a call to do_sofirq() is pending K Prateek Nayak
2024-09-04 13:49 ` [RFC PATCH v2 0/5] Idle Load Balance fixes and softirq enhancements K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904121513.GH4723@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Julia.Lawall@inria.fr \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=csander@purestorage.com \
--cc=dietmar.eggemann@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=jiangshanlai@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=leobras@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@toblux.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox