From: Jason Gunthorpe <jgg@ziepe.ca>
To: Liu Jing <liujing@cmss.chinamobile.com>
Cc: kevin.tian@intel.com, shuah@kernel.org, iommu@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommufd/selftest:fix a resource leak
Date: Wed, 4 Sep 2024 13:10:27 -0300 [thread overview]
Message-ID: <20240904161027.GD1909087@ziepe.ca> (raw)
In-Reply-To: <20240903200806.9803-1-liujing@cmss.chinamobile.com>
On Wed, Sep 04, 2024 at 04:08:06AM +0800, Liu Jing wrote:
> If the file fails to open, not only return return1 but also close the file descriptor,otherwise resource
> leak will occur
Why doesn't FIXURE_TEARDOWN do this?
Jason
prev parent reply other threads:[~2024-09-04 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 20:08 [PATCH] iommufd/selftest:fix a resource leak Liu Jing
2024-09-04 16:10 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904161027.GD1909087@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox