Re: [PATCH 01/19] rust: workqueue: remove unneeded ``#[allow(clippy::new_ret_no_self)]`

Trevor Gross
2024-09-29T04:18:08Z

On Wed, Sep 4, 2024 at 4:44 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Perform the same clean commit b2516f7af9d2 ("rust: kernel: remove
> `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in
> workqueue in parallel in commit 7324b88975c5 ("rust: workqueue: add
> helper for defining work_struct fields"):
>
> Clippy triggered a false positive on its `new_ret_no_self` lint
> when using the `pin_init!` macro. Since Rust 1.67.0, that does
> not happen anymore, since Clippy learnt to not warn about
> `-> impl Trait<Self>` [1][2].
>
> The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`.
>
> Link: https://github.com/rust-lang/rust-clippy/issues/7344 [1]
> Link: https://github.com/rust-lang/rust-clippy/pull/9733 [2]
>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Trevor Gross <tmgross@umich.edu>