[PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[Rosen Penev]

No need for the mask when there's already a macro for this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/phy/qcom/qca83xx.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/net/phy/qcom/qca83xx.c b/drivers/net/phy/qcom/qca83xx.c
index 5d083ef0250e..a05d0df6fa16 100644
--- a/drivers/net/phy/qcom/qca83xx.c
+++ b/drivers/net/phy/qcom/qca83xx.c
@@ -15,7 +15,6 @@
 #define QCA8327_A_PHY_ID			0x004dd033
 #define QCA8327_B_PHY_ID			0x004dd034
 #define QCA8337_PHY_ID				0x004dd036
-#define QCA8K_PHY_ID_MASK			0xffffffff
 
 #define QCA8K_DEVFLAGS_REVISION_MASK		GENMASK(2, 0)
 
@@ -216,8 +215,7 @@ static int qca8327_suspend(struct phy_device *phydev)
 static struct phy_driver qca83xx_driver[] = {
 {
 	/* QCA8337 */
-	.phy_id			= QCA8337_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8337_PHY_ID),
 	.name			= "Qualcomm Atheros 8337 internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.probe			= qca83xx_probe,
@@ -231,8 +229,7 @@ static struct phy_driver qca83xx_driver[] = {
 	.resume			= qca83xx_resume,
 }, {
 	/* QCA8327-A from switch QCA8327-AL1A */
-	.phy_id			= QCA8327_A_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8327_A_PHY_ID),
 	.name			= "Qualcomm Atheros 8327-A internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.link_change_notify	= qca83xx_link_change_notify,
@@ -247,8 +244,7 @@ static struct phy_driver qca83xx_driver[] = {
 	.resume			= qca83xx_resume,
 }, {
 	/* QCA8327-B from switch QCA8327-BL1A */
-	.phy_id			= QCA8327_B_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8327_B_PHY_ID),
 	.name			= "Qualcomm Atheros 8327-B internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.link_change_notify	= qca83xx_link_change_notify,
-- 
2.46.0

Re: [PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[Andrew Lunn]

On Wed, Sep 04, 2024 at 01:56:59PM -0700, Rosen Penev wrote:
> No need for the mask when there's already a macro for this.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

The Subject should be [PATCH net-next]. Yes, we all keep forgetting
it, but it is important to the CI.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[Rosen Penev]

On Wed, Sep 4, 2024 at 2:43 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Wed, Sep 04, 2024 at 01:56:59PM -0700, Rosen Penev wrote:
> > No need for the mask when there's already a macro for this.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> The Subject should be [PATCH net-next]. Yes, we all keep forgetting
> it, but it is important to the CI.
Procedural mistake. Need to use --subject-prefix looks like. Should I resend?
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
>     Andrew

Re: [PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[Andrew Lunn]

> Procedural mistake. Need to use --subject-prefix looks like. Should I resend?

Wait 3 days. If it does not get merged, please do resend.

     Andrew

Re: [PATCH] net: phy: qca83xx: use PHY_ID_MATCH_EXACT

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 Sep 2024 13:56:59 -0700 you wrote:
> No need for the mask when there's already a macro for this.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/net/phy/qcom/qca83xx.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Here is the summary with links:
  - net: phy: qca83xx: use PHY_ID_MATCH_EXACT
    https://git.kernel.org/netdev/net-next/c/cca0d69baf95

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html