* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-01 16:15 [PATCH 4.19 00/98] 4.19.321-rc1 review Greg Kroah-Hartman
@ 2024-09-02 7:10 ` Pavel Machek
2024-09-02 8:46 ` Naresh Kamboju
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Pavel Machek @ 2024-09-02 7:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.19.321 release.
> There are 98 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-01 16:15 [PATCH 4.19 00/98] 4.19.321-rc1 review Greg Kroah-Hartman
2024-09-02 7:10 ` Pavel Machek
@ 2024-09-02 8:46 ` Naresh Kamboju
2024-09-04 9:30 ` Greg Kroah-Hartman
2024-09-02 9:00 ` Naresh Kamboju
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2024-09-02 8:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Anders Roxell, abdulrasaqolawani, Helge Deller
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.19.321 release.
> There are 98 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The Powerpc defconfig builds failed on Linux stable-rc due to following
build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on
- 4.19.321-rc1 review
- 5.4.283-rc1 review
- 5.10.225-rc1 review
- 5.15.166-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Anders bisected this to first bad commit id as,
fbdev: offb: replace of_node_put with __free(device_node)
[ Upstream commit ce4a7ae84a58b9f33aae8d6c769b3c94f3d5ce76 ]
build log:
--------
kernel/profile.c: In function 'profile_dead_cpu':
kernel/profile.c:346:27: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
346 | if (prof_cpu_mask != NULL)
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
kernel/profile.c: In function 'profile_online_cpu':
kernel/profile.c:383:27: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
383 | if (prof_cpu_mask != NULL)
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
kernel/profile.c: In function 'profile_tick':
kernel/profile.c:413:47: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
413 | if (!user_mode(regs) && prof_cpu_mask != NULL &&
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
fs/xfs/libxfs/xfs_inode_fork.c: In function 'xfs_ifork_verify_attr':
fs/xfs/libxfs/xfs_inode_fork.c:731:13: warning: the comparison will
always evaluate as 'true' for the address of 'i_df' will never be NULL
[-Waddress]
731 | if (!XFS_IFORK_PTR(ip, XFS_ATTR_FORK))
| ^
In file included from fs/xfs/libxfs/xfs_inode_fork.c:14:
fs/xfs/xfs_inode.h:38:33: note: 'i_df' declared here
38 | struct xfs_ifork i_df; /* data fork */
| ^~~~
drivers/video/fbdev/offb.c: In function 'offb_init_palette_hacks':
drivers/video/fbdev/offb.c:355:47: error: expected '=', ',', ';',
'asm' or '__attribute__' before '__free'
355 | struct device_node *pciparent
__free(device_node) = of_get_parent(dp);
| ^~~~~~
drivers/video/fbdev/offb.c:355:47: error: implicit declaration of
function '__free'; did you mean 'kzfree'?
[-Werror=implicit-function-declaration]
355 | struct device_node *pciparent
__free(device_node) = of_get_parent(dp);
| ^~~~~~
| kzfree
drivers/video/fbdev/offb.c:355:54: error: 'device_node' undeclared
(first use in this function)
355 | struct device_node *pciparent
__free(device_node) = of_get_parent(dp);
| ^~~~~~~~~~~
drivers/video/fbdev/offb.c:355:54: note: each undeclared identifier is
reported only once for each function it appears in
drivers/video/fbdev/offb.c:356:17: warning: ISO C90 forbids mixed
declarations and code [-Wdeclaration-after-statement]
356 | const u32 *vid, *did;
| ^~~~~
drivers/video/fbdev/offb.c:357:39: error: 'pciparent' undeclared
(first use in this function); did you mean 'pci_alert'?
357 | vid = of_get_property(pciparent, "vendor-id", NULL);
| ^~~~~~~~~
| pci_alert
cc1: some warnings being treated as errors
Build Log links,
--------
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.320-99-g0cc44dd838a6/testrun/24994095/suite/build/test/gcc-12-ppc64e_defconfig/log
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-02 8:46 ` Naresh Kamboju
@ 2024-09-04 9:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-04 9:30 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Anders Roxell, abdulrasaqolawani, Helge Deller
On Mon, Sep 02, 2024 at 02:16:48PM +0530, Naresh Kamboju wrote:
> On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.321 release.
> > There are 98 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> The Powerpc defconfig builds failed on Linux stable-rc due to following
> build warnings / errors with clang-18 and gcc-12.
>
> This is a same problem on current stable-rc review on
> - 4.19.321-rc1 review
> - 5.4.283-rc1 review
> - 5.10.225-rc1 review
> - 5.15.166-rc1 review
>
> In the case of stable-rc linux-4.19.y
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Anders bisected this to first bad commit id as,
> fbdev: offb: replace of_node_put with __free(device_node)
> [ Upstream commit ce4a7ae84a58b9f33aae8d6c769b3c94f3d5ce76 ]
Now dropped, thanks.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-01 16:15 [PATCH 4.19 00/98] 4.19.321-rc1 review Greg Kroah-Hartman
2024-09-02 7:10 ` Pavel Machek
2024-09-02 8:46 ` Naresh Kamboju
@ 2024-09-02 9:00 ` Naresh Kamboju
2024-09-04 9:38 ` Greg Kroah-Hartman
2024-09-02 9:14 ` Harshit Mogalapalli
2024-09-03 8:42 ` Jon Hunter
4 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2024-09-02 9:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Anders Roxell, aleksander.lobakin, David S. Miller
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.19.321 release.
> There are 98 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Apart from Powerpc build regressions we have noticed s390 build regression.
The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to
following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on
- 4.19.321-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Following two commits have been added on 4.19.321-rc1.
-------
s390/cio: rename bitmap_size() -> idset_bitmap_size()
commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
bitmap: introduce generic optimized bitmap_size()
commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
build log:
--------
drivers/s390/cio/idset.c: In function 'idset_bitmap_size':
drivers/s390/cio/idset.c:21:28: error: implicit declaration of
function 'size_mul' [-Werror=implicit-function-declaration]
21 | return bitmap_size(size_mul(num_ssid, num_id));
| ^~~~~~~~
include/uapi/linux/const.h:32:44: note: in definition of macro
'__ALIGN_KERNEL_MASK'
32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
| ^
include/linux/kernel.h:58:33: note: in expansion of macro '__ALIGN_KERNEL'
58 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
include/linux/bitmap.h:215:34: note: in expansion of macro 'ALIGN'
215 | #define bitmap_size(nbits) (ALIGN(nbits, BITS_PER_LONG) /
BITS_PER_BYTE)
| ^~~~~
drivers/s390/cio/idset.c:21:16: note: in expansion of macro 'bitmap_size'
21 | return bitmap_size(size_mul(num_ssid, num_id));
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
Build Log links,
--------
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.320-99-g0cc44dd838a6/testrun/24994013/suite/build/test/gcc-12-defconfig/log
metadata:
----
git describe: v4.19.320-99-g0cc44dd838a6
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git sha: 0cc44dd838a6e3fee60d7af3ca412c4d1b824562
kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2lTf8qakoJKDjTgS3TvH3naApk1/config
build url: https://storage.tuxsuite.com/public/linaro/lkft/builds/2lTf8qakoJKDjTgS3TvH3naApk1/
toolchain: clang-18 and gcc-12
config: defconfig
arch: S390
Steps to reproduce:
---------
- tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
--kconfig defconfig
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-02 9:00 ` Naresh Kamboju
@ 2024-09-04 9:38 ` Greg Kroah-Hartman
2024-09-04 9:46 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-04 9:38 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Anders Roxell, aleksander.lobakin, David S. Miller
On Mon, Sep 02, 2024 at 02:30:57PM +0530, Naresh Kamboju wrote:
> On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.321 release.
> > There are 98 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Apart from Powerpc build regressions we have noticed s390 build regression.
> The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to
> following build warnings / errors with clang-18 and gcc-12.
>
> This is a same problem on current stable-rc review on
> - 4.19.321-rc1 review
>
> In the case of stable-rc linux-4.19.y
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Following two commits have been added on 4.19.321-rc1.
> -------
> s390/cio: rename bitmap_size() -> idset_bitmap_size()
> commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
>
> bitmap: introduce generic optimized bitmap_size()
> commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
Odd, this should have also shown up in your 5.4.y builds too.
I'll go drop this from both trees now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-04 9:38 ` Greg Kroah-Hartman
@ 2024-09-04 9:46 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-04 9:46 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Anders Roxell, aleksander.lobakin, David S. Miller
On Wed, Sep 04, 2024 at 11:38:05AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 02, 2024 at 02:30:57PM +0530, Naresh Kamboju wrote:
> > On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 4.19.321 release.
> > > There are 98 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Apart from Powerpc build regressions we have noticed s390 build regression.
> > The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to
> > following build warnings / errors with clang-18 and gcc-12.
> >
> > This is a same problem on current stable-rc review on
> > - 4.19.321-rc1 review
> >
> > In the case of stable-rc linux-4.19.y
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Following two commits have been added on 4.19.321-rc1.
> > -------
> > s390/cio: rename bitmap_size() -> idset_bitmap_size()
> > commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
> >
> > bitmap: introduce generic optimized bitmap_size()
> > commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
>
> Odd, this should have also shown up in your 5.4.y builds too.
>
> I'll go drop this from both trees now, thanks.
Nope, I need it there, I'll go add some helper functions to make this
work, thanks.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-01 16:15 [PATCH 4.19 00/98] 4.19.321-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-09-02 9:00 ` Naresh Kamboju
@ 2024-09-02 9:14 ` Harshit Mogalapalli
2024-09-04 9:51 ` Greg Kroah-Hartman
2024-09-03 8:42 ` Jon Hunter
4 siblings, 1 reply; 10+ messages in thread
From: Harshit Mogalapalli @ 2024-09-02 9:14 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie, Vegard Nossum
Hi Greg,
On 01/09/24 21:45, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.321 release.
> There are 98 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> Anything received after that time might be too late.
Build fails on our infrastructure.
BUILDSTDERR: In file included from
/builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/bitmap.h:6,
BUILDSTDERR: from
/builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/perf/util/include/../../util/pmu.h:5,
BUILDSTDERR: from arch/x86/util/pmu.c:9:
BUILDSTDERR:
/builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/align.h:6:10:
fatal error: uapi/linux/const.h: No such file or directory
BUILDSTDERR: #include <uapi/linux/const.h>
BUILDSTDERR: ^~~~~~~~~~~~~~~~~~~~
BUILDSTDERR: compilation terminated.
Looked at the commits:
This commit 993a20bf6225c: ("tools: move alignment-related macros to new
<linux/align.h>") is causing that perf build to fail.
Solution is not to drop this patch as this is probably pulled in to
support bitmap_size() macros in these commits(which are also part of
this release):
6fbe5a3920f48 fix bitmap corruption on close_range() with
CLOSE_RANGE_UNSHARE
ef9ebc42c10f8 bitmap: introduce generic optimized bitmap_size()
Applying the below diff, helps the perf build to pass: I think we should
fold this into: commit 993a20bf6225c: ("tools: move alignment-related
macros to new <linux/align.h>")
diff --git a/tools/include/linux/align.h b/tools/include/linux/align.h
index 14e34ace80dda..a27bc1edf6e5c 100644
--- a/tools/include/linux/align.h
+++ b/tools/include/linux/align.h
@@ -3,7 +3,7 @@
#ifndef _TOOLS_LINUX_ALIGN_H
#define _TOOLS_LINUX_ALIGN_H
-#include <uapi/linux/const.h>
+#include <linux/const.h>
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
#define ALIGN_DOWN(x, a) __ALIGN_KERNEL((x) - ((a) - 1), (a))
!! But this breaks the build for arm here.
!! Not sure what is the best way to solve this problem.
Thanks,
Harshit
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-02 9:14 ` Harshit Mogalapalli
@ 2024-09-04 9:51 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-04 9:51 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Vegard Nossum
On Mon, Sep 02, 2024 at 02:44:44PM +0530, Harshit Mogalapalli wrote:
> Hi Greg,
>
> On 01/09/24 21:45, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.19.321 release.
> > There are 98 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> > Anything received after that time might be too late.
>
> Build fails on our infrastructure.
>
>
> BUILDSTDERR: In file included from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/bitmap.h:6,
> BUILDSTDERR: from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/perf/util/include/../../util/pmu.h:5,
> BUILDSTDERR: from arch/x86/util/pmu.c:9:
> BUILDSTDERR: /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/align.h:6:10:
> fatal error: uapi/linux/const.h: No such file or directory
> BUILDSTDERR: #include <uapi/linux/const.h>
> BUILDSTDERR: ^~~~~~~~~~~~~~~~~~~~
> BUILDSTDERR: compilation terminated.
>
>
> Looked at the commits:
>
> This commit 993a20bf6225c: ("tools: move alignment-related macros to new
> <linux/align.h>") is causing that perf build to fail.
>
> Solution is not to drop this patch as this is probably pulled in to support
> bitmap_size() macros in these commits(which are also part of this release):
>
> 6fbe5a3920f48 fix bitmap corruption on close_range() with
> CLOSE_RANGE_UNSHARE
> ef9ebc42c10f8 bitmap: introduce generic optimized bitmap_size()
>
>
>
> Applying the below diff, helps the perf build to pass: I think we should
> fold this into: commit 993a20bf6225c: ("tools: move alignment-related macros
> to new <linux/align.h>")
>
> diff --git a/tools/include/linux/align.h b/tools/include/linux/align.h
> index 14e34ace80dda..a27bc1edf6e5c 100644
> --- a/tools/include/linux/align.h
> +++ b/tools/include/linux/align.h
> @@ -3,7 +3,7 @@
> #ifndef _TOOLS_LINUX_ALIGN_H
> #define _TOOLS_LINUX_ALIGN_H
>
> -#include <uapi/linux/const.h>
> +#include <linux/const.h>
>
> #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
> #define ALIGN_DOWN(x, a) __ALIGN_KERNEL((x) - ((a) - 1), (a))
Change now made, thanks.
> !! But this breaks the build for arm here.
> !! Not sure what is the best way to solve this problem.
Are people building perf for arm on 4.19.y? If so, wow, this thing is
about to go end-of-life any week now, and I would be amazed if it built
at all anymore as I can't get perf to build on _ANY_ lts kernel these
days.
Anyway, I'll make this change and if any arm build fixes want to show
up, I'll be glad to take them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.19 00/98] 4.19.321-rc1 review
2024-09-01 16:15 [PATCH 4.19 00/98] 4.19.321-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2024-09-02 9:14 ` Harshit Mogalapalli
@ 2024-09-03 8:42 ` Jon Hunter
4 siblings, 0 replies; 10+ messages in thread
From: Jon Hunter @ 2024-09-03 8:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
linux-tegra, stable
On Sun, 01 Sep 2024 18:15:30 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.321 release.
> There are 98 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v4.19:
10 builds: 10 pass, 0 fail
20 boots: 20 pass, 0 fail
37 tests: 37 pass, 0 fail
Linux version: 4.19.321-rc1-g0cc44dd838a6
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 10+ messages in thread