Re: [PATCH 02/18] drm/i915/selftests: Include instead of

Jani Nikula
2024-09-05T13:06:12Z

On Thu, 05 Sep 2024, Uros Bizjak <ubizjak@gmail.com> wrote:
> Usage of pseudo-random functions requires inclusion of
> <linux/prandom.h> header instead of <linux/random.h>.
>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tursulin@ursulin.net>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org

LGTM,

Acked-by: Jani Nikula <jani.nikula@intel.com>

for merging via whichever tree suits you best.

> ---
> drivers/gpu/drm/i915/selftests/i915_gem.c | 2 +-
> drivers/gpu/drm/i915/selftests/i915_random.h | 2 +-
> drivers/gpu/drm/i915/selftests/scatterlist.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index 61da4ed9d521..0727492576be 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
> @@ -4,7 +4,7 @@
> * Copyright © 2018 Intel Corporation
> */
>
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>
> #include "gem/i915_gem_internal.h"
> #include "gem/i915_gem_pm.h"
> diff --git a/drivers/gpu/drm/i915/selftests/i915_random.h b/drivers/gpu/drm/i915/selftests/i915_random.h
> index 05364eca20f7..70330a2e80f2 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_random.h
> +++ b/drivers/gpu/drm/i915/selftests/i915_random.h
> @@ -26,7 +26,7 @@
> #define __I915_SELFTESTS_RANDOM_H__
>
> #include <linux/math64.h>
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>
> #include "../i915_selftest.h"
>
> diff --git a/drivers/gpu/drm/i915/selftests/scatterlist.c b/drivers/gpu/drm/i915/selftests/scatterlist.c
> index 805c4bfb85fe..7e59591bbed6 100644
> --- a/drivers/gpu/drm/i915/selftests/scatterlist.c
> +++ b/drivers/gpu/drm/i915/selftests/scatterlist.c
> @@ -22,7 +22,7 @@
> */
>
> #include <linux/prime_numbers.h>
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>
> #include "i915_selftest.h"
> #include "i915_utils.h"

--
Jani Nikula, Intel