From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E85019995A; Thu, 5 Sep 2024 12:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725539811; cv=none; b=tb6ZBkcNbQrPPk1hmNkZnoYsmXT3k5C51dAIlN+AhZkp1kGpajbnxW/9HkVUY7XkTJ3RIDw4u0Jdi0Ihft0CbRvlYw8TOJxv/hd2ymvO+IyN1gT5SqP8ZcCeYJDq7lYWZs5Q8IYRhzatsVZ9F1tfkHQA37M2MES5rrEV4AXPIdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725539811; c=relaxed/simple; bh=6TPgiZade1O1R8CV8OI6tD+3w66GZTqc6tH80dP1Zeg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O+UG/6Q0nRurOKL35D+qb3j4RB4LE5BPO0TYJ2Yrj39AZek7gSPCrK9CRkibx2bpnb7341u1mQ5KlZnLR6+RuJDtYYb92z7cjMrw7KRpP3EnTyif7poWmLExOtdCHaVm2FNRgz7j8Sngd83pnHOVz+HbY/+MvAg94mf4uJSGnNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=mbBEC+xk; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="mbBEC+xk" Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2FCFD88CA2; Thu, 5 Sep 2024 14:36:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1725539806; bh=ayWTD1xmfUa1G8AZggnBVtNMYzzsNAqygwbctMF+fYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mbBEC+xkwFodZ/KezcmL8qTMGgDn+pNSozmRwSb4E6Mt7zimO1/0+gOm+W1Dn1vIW Ea7Bj2YBQDF+5YsWH4zWF9SATNyZBUvwJo3z47cvGRueH74ShekM01OHj42yaoQXhl kSSoj4bj06WSSSklS96eecEQpd3XzzkJYeXFLl/1AAKVFnYIlVxdYzUOIAtYj9uja/ F8/NnExDq8d/9hHgRWZZsHGWmMwtYAVr5C79OI06D9WP1S8+/rZDvDJj7dUXZyfMXm pQ7pRdtr5mUd4RJEyMpQ9eIvCScTEMHhgoUcxmi40NZKTrwt5MtJtFJz7B3pPTX/Kk 38w44X9VQffow== Date: Thu, 5 Sep 2024 14:36:45 +0200 From: Lukasz Majewski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] dts: nxp: mxs: Add descriptions for imx287 based btt3-[012] devices Message-ID: <20240905143645.7946fb0e@wsk> In-Reply-To: <20240830085441.3589713-1-lukma@denx.de> References: <20240830085441.3589713-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xCvPC9dVmn5AXrHjFKCGFF1"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Sig_/xCvPC9dVmn5AXrHjFKCGFF1 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Fabio, > The btt3 device' HW revisions from 0 to 2 use imx287 SoC and are to > some extend similar to already upstreamed XEA devices, hence are > using common imx28-lwe.dtsi file. >=20 > New, imx28-btt3.dtsi has been added to embrace common DTS > properties for different HW revisions for this device. >=20 > As a result - changes introduced in imx28-btt3-[012].dts are > minimal. >=20 > Signed-off-by: Lukasz Majewski >=20 > --- >=20 > Changes for v2: > - Rename dts file from btt3-[012] to imx28-btt3-[012] to match current > linux kernel naming convention > - Remove 'wlf,wm8974' from compatible for codec@1a >=20 > Changes for v3: > - Keep alphabethical order for Makefile entries Fabio, do you have more comments for this patch set? > --- > arch/arm/boot/dts/nxp/mxs/Makefile | 3 + > arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts | 12 + > arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts | 8 + > arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts | 12 + > arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi | 320 > +++++++++++++++++++++ 5 files changed, 355 insertions(+) > create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts > create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts > create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts > create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi >=20 > diff --git a/arch/arm/boot/dts/nxp/mxs/Makefile > b/arch/arm/boot/dts/nxp/mxs/Makefile index a430d04f9c69..96dd31ea19ba > 100644 --- a/arch/arm/boot/dts/nxp/mxs/Makefile > +++ b/arch/arm/boot/dts/nxp/mxs/Makefile > @@ -8,6 +8,9 @@ dtb-$(CONFIG_ARCH_MXS) +=3D \ > imx28-apf28.dtb \ > imx28-apf28dev.dtb \ > imx28-apx4devkit.dtb \ > + imx28-btt3-0.dtb \ > + imx28-btt3-1.dtb \ > + imx28-btt3-2.dtb \ > imx28-cfa10036.dtb \ > imx28-cfa10037.dtb \ > imx28-cfa10049.dtb \ > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts > b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts new file mode 100644 > index 000000000000..6ac46e4b21bb > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2024 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; > +#include "imx28-btt3.dtsi" > + > +&hog_pins_rev { > + fsl,pull-up =3D ; > +}; > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts > b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts new file mode 100644 > index 000000000000..213fe931c58b > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2024 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; > +#include "imx28-btt3.dtsi" > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts > b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts new file mode 100644 > index 000000000000..c787c2d03463 > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2024 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; > +#include "imx28-btt3.dtsi" > + > +&lcdif { > + display =3D <&display_te_b>; > +}; > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi > b/arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi new file mode 100644 > index 000000000000..27a01e925e26 > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi > @@ -0,0 +1,320 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2024 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > +/dts-v1/; > +#include "imx28-lwe.dtsi" > + > +/ { > + model =3D "BTT3"; > + > + compatible =3D "lwn,btt3", "fsl,imx28"; > + > + chosen { > + bootargs =3D "root=3D/dev/mmcblk0p2 rootfstype=3Dext4 ro > rootwait console=3DttyAMA0,115200 panic=3D1 quiet"; > + }; > + > + memory@40000000 { > + reg =3D <0x40000000 0x10000000>; > + device_type =3D "memory"; > + }; > + > + poweroff { > + compatible =3D "gpio-poweroff"; > + gpios =3D <&gpio0 24 0>; > + }; > + > + sound { > + compatible =3D "simple-audio-card"; > + simple-audio-card,name =3D "BTTC Audio"; > + simple-audio-card,widgets =3D "Speaker", "BTTC > Speaker"; > + simple-audio-card,routing =3D "BTTC Speaker", > "SPKOUTN", "BTTC Speaker", "SPKOUTP"; > + simple-audio-card,dai-link@0 { > + format =3D "left_j"; > + bitclock-master =3D <&dai0_master>; > + frame-master =3D <&dai0_master>; > + mclk-fs =3D <256>; > + dai0_master: cpu { > + sound-dai =3D <&saif0>; > + }; > + codec { > + sound-dai =3D <&wm89xx>; > + clocks =3D <&saif0>; > + }; > + }; > + }; > + > + wifi_pwrseq: sdio-pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&wifi_en_pin_bttc>; > + reset-gpios =3D <&gpio0 27 GPIO_ACTIVE_LOW>; > + /* W1-163 needs 60us for WL_EN to be low and */ > + /* 150ms after high before downloading FW is > possible */ > + post-power-on-delay-ms =3D <200>; > + power-off-delay-us =3D <100>; > + }; > +}; > + > +&auart0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&auart0_2pins_a>; > + status =3D "okay"; > +}; > + > +&auart3 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&auart3_pins_a>; > + uart-has-rtscts; > + status =3D "okay"; > +}; > + > +&i2c0 { > + wm89xx: codec@1a { > + compatible =3D "wlf,wm8940"; > + reg =3D <0x1a>; > + #sound-dai-cells =3D <0>; > + }; > +}; > + > +&lcdif { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&lcdif_24bit_pins_a>, <&lcdif_sync_pins_bttc>, > + <&lcdif_reset_pins_bttc>; > + lcd-supply =3D <®_3v3>; > + display =3D <&display0>; > + status =3D "okay"; > + display0: display0 { > + bits-per-pixel =3D <32>; > + bus-width =3D <24>; > + display-timings { > + native-mode =3D <&timing0>; > + timing0: timing0 { > + clock-frequency =3D <6500000>; > + hactive =3D <320>; > + vactive =3D <240>; > + hfront-porch =3D <20>; > + hback-porch =3D <38>; > + hsync-len =3D <30>; > + vfront-porch =3D <4>; > + vback-porch =3D <14>; > + vsync-len =3D <4>; > + hsync-active =3D <0>; > + vsync-active =3D <0>; > + de-active =3D <0>; > + pixelclk-active =3D <1>; > + }; > + }; > + }; > + display_te_b: display1 { > + bits-per-pixel =3D <32>; > + bus-width =3D <24>; > + display-timings { > + native-mode =3D <&timing0>; > + timing_te_b: timing0 { > + clock-frequency =3D <6500000>; > + hactive =3D <320>; > + vactive =3D <240>; > + hfront-porch =3D <20>; > + hback-porch =3D <68>; > + hsync-len =3D <30>; > + vfront-porch =3D <4>; > + vback-porch =3D <14>; > + vsync-len =3D <4>; > + hsync-active =3D <0>; > + vsync-active =3D <0>; > + de-active =3D <1>; > + pixelclk-active =3D <1>; > + }; > + }; > + }; > + > +}; > + > +&mac0 { > + clocks =3D <&clks 57>, <&clks 57>, <&clks 64>; > + clock-names =3D "ipg", "ahb", "enet_out"; > + phy-handle =3D <&mac0_phy>; > + phy-mode =3D "rmii"; > + phy-supply =3D <®_3v3>; > + local-mac-address =3D [ 00 11 B8 00 BF 8A ]; > + status =3D "okay"; > + > + mdio { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + mac0_phy: ethernet-phy@0 { > + /* LAN8720Ai - PHY ID */ > + compatible =3D > "ethernet-phy-id0007.c0f0","ethernet-phy-ieee802.3-c22"; > + reg =3D <0>; > + smsc,disable-energy-detect; > + max-speed =3D <100>; > + > + reset-gpios =3D <&gpio4 12 GPIO_ACTIVE_LOW>; > /* GPIO4_12 */ > + reset-assert-us =3D <1000>; > + reset-deassert-us =3D <1000>; > + }; > + }; > +}; > + > +&pinctrl { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&hog_pins_a>, <&hog_pins_rev>; > + > + hog_pins_a: hog@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + MX28_PAD_GPMI_RDY2__GPIO_0_22 > + MX28_PAD_GPMI_RDY3__GPIO_0_23 > + MX28_PAD_GPMI_RDN__GPIO_0_24 > + MX28_PAD_LCD_VSYNC__GPIO_1_28 > + MX28_PAD_SSP2_SS1__GPIO_2_20 > + MX28_PAD_SSP2_SS2__GPIO_2_21 > + MX28_PAD_AUART2_CTS__GPIO_3_10 > + MX28_PAD_AUART2_RTS__GPIO_3_11 > + MX28_PAD_GPMI_WRN__GPIO_0_25 > + MX28_PAD_ENET0_RXD2__GPIO_4_9 > + MX28_PAD_ENET0_TXD2__GPIO_4_11 > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + hog_pins_rev: hog@1 { > + reg =3D <1>; > + fsl,pinmux-ids =3D < > + MX28_PAD_ENET0_RXD3__GPIO_4_10 > + MX28_PAD_ENET0_TX_CLK__GPIO_4_5 > + MX28_PAD_ENET0_COL__GPIO_4_14 > + MX28_PAD_ENET0_CRS__GPIO_4_15 > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + keypad_pins_bttc: keypad-bttc@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + MX28_PAD_GPMI_D00__GPIO_0_0 > + MX28_PAD_AUART0_CTS__GPIO_3_2 > + MX28_PAD_AUART0_RTS__GPIO_3_3 > + MX28_PAD_GPMI_D03__GPIO_0_3 > + MX28_PAD_GPMI_D04__GPIO_0_4 > + MX28_PAD_GPMI_D05__GPIO_0_5 > + MX28_PAD_GPMI_D06__GPIO_0_6 > + MX28_PAD_GPMI_D07__GPIO_0_7 > + MX28_PAD_GPMI_CE1N__GPIO_0_17 > + MX28_PAD_GPMI_CE2N__GPIO_0_18 > + MX28_PAD_GPMI_CE3N__GPIO_0_19 > + MX28_PAD_GPMI_RDY0__GPIO_0_20 > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + lcdif_sync_pins_bttc: lcdif-bttc@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + MX28_PAD_LCD_DOTCLK__LCD_DOTCLK > + MX28_PAD_LCD_ENABLE__LCD_ENABLE > + MX28_PAD_LCD_HSYNC__LCD_HSYNC > + MX28_PAD_LCD_RD_E__LCD_VSYNC > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + lcdif_reset_pins_bttc: lcdif-bttc@1 { > + reg =3D <1>; > + fsl,pinmux-ids =3D < > + MX28_PAD_LCD_RESET__GPIO_3_30 > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + ssp1_sdio_pins_a: ssp1-sdio@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + MX28_PAD_SSP1_DATA0__SSP1_D0 > + MX28_PAD_GPMI_D01__SSP1_D1 > + MX28_PAD_GPMI_D02__SSP1_D2 > + MX28_PAD_SSP1_DATA3__SSP1_D3 > + MX28_PAD_SSP1_CMD__SSP1_CMD > + MX28_PAD_SSP1_SCK__SSP1_SCK > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > + > + wifi_en_pin_bttc: wifi_en_pin@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + MX28_PAD_GPMI_CLE__GPIO_0_27 > + >; > + fsl,drive-strength =3D ; > + fsl,voltage =3D ; > + fsl,pull-up =3D ; > + }; > +}; > + > +&pwm { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pwm3_pins_a>; > + status =3D "okay"; > +}; > + > +®_usb_5v { > + gpio =3D <&gpio1 28 0>; > +}; > + > +&saif0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&saif0_pins_a>; > + #sound-dai-cells =3D <0>; > + assigned-clocks =3D <&clks 53>; > + assigned-clock-rates =3D <12000000>; > + status =3D "okay"; > +}; > + > +&saif1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&saif1_pins_a>; > + fsl,saif-master =3D <&saif0>; > + #sound-dai-cells =3D <0>; > + status =3D "okay"; > +}; > + > +&ssp1 { > + compatible =3D "fsl,imx28-mmc"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&ssp1_sdio_pins_a>; > + bus-width =3D <4>; > + no-1-8-v; /* force 3.3V VIO */ > + pm-ignore-notify; > + non-removable; > + vmmc-supply =3D <®_3v3>; > + mmc-pwrseq =3D <&wifi_pwrseq>; > + keep-power-in-suspend; > + status =3D "okay"; > + > + wlan@1 { > + reg =3D <1>; > + compatible =3D "brcm,bcm4329-fmac"; > + }; > +}; > + > +&ssp2 { > + compatible =3D "fsl,imx28-spi"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi2_pins_a>; > + status =3D "okay"; > +}; Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/xCvPC9dVmn5AXrHjFKCGFF1 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmbZpd0ACgkQAR8vZIA0 zr1AyAgAiGGgQV6Ea/Ndjy7S8msepYLi4bSSR8zcma3xBHZcgP5EbmTYxBdAYU52 vl75D6cXMUChLQ3WgtW/DugSwl2I2tVkpi45bPoCU3IV94IpYNbm5AltzilIme0S iE6/NV1FDRCDKTviPA9kwubv6lnhkCA73jcVrpqfZK/5I05DdL8XIT7cxbtCsL0E L15O7CRO/MgkAUWn6DtDyrbrYFUC/52Iu1kvqb5g+D8mvdfoqiEb2XV201TWd8g3 lfxBt2txZZeb7PYVIVRmqu16aVT8ocTdH+nFP3ayzEvkkAo1ijGLOFy/tWKzPm3w dv+cJD/SomKHruZBvYcieH0yjK2tPQ== =xssw -----END PGP SIGNATURE----- --Sig_/xCvPC9dVmn5AXrHjFKCGFF1--