Re: [PATCH v1 1/1] x86/percpu: Cast -1 to argument type when comparing in percpu_add_op()

Nick Desaulniers
2024-10-16T17:03:26Z

On Wed, Oct 16, 2024 at 8:45 AM Dave Hansen <dave.hansen@intel.com> wrote:
> Since I'm making comments, I would have really appreciated some extra
> info here like why you are hitting this and nobody else is. This is bog
> standard code that everybody compiles. Is clang use _that_ unusual? Or
> do most clang users just ignore all the warnings? Or are you using a
> bleeding edge version of clang that spits out new warnings that other
> clang users aren't seeing?

Note the W=1 part in the commit message. That's the part people
generally don't test with, but the bots do.

On Thu, Sep 5, 2024 at 10:04 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When percpu_add_op() is used with unsigned argument, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:

--
Thanks,
~Nick Desaulniers