Re: [PATCH net-next 4/9] net: netconsole: rename body to msg_body

Simon Horman
2024-09-04T11:03:01Z

On Tue, Sep 03, 2024 at 07:07:47AM -0700, Breno Leitao wrote:
> With the introduction of the userdata concept, the term body has become
> ambiguous and less intuitive.
>
> To improve clarity, body is renamed to msg_body, making it clear that

nit: the patch uses msgbody

> the body is not the only content following the header.
>
> In an upcoming patch, the term body_len will also be revised for further
> clarity.
>
> The current packet structure is as follows:
>
> release, header, body, [msg_body + userdata]
>
> Here, [msg_body + userdata] collectively forms what is currently
> referred to as "body." This renaming helps to distinguish and better
> understand each component of the packet.

Thanks, IMHO, clear terminology is very important:
it's hard to discuss what you can't clearly name.

>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Code changes are a mechanical update and look good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

...