From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ruffalo Lavoisier <ruffalolavoisier@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ni_routing: Check when the file could not be opened
Date: Fri, 6 Sep 2024 13:59:25 +0200 [thread overview]
Message-ID: <2024090629-exploit-striving-d2c3@gregkh> (raw)
In-Reply-To: <20240906115402.30894-1-RuffaloLavoisier@gmail.com>
On Fri, Sep 06, 2024 at 08:54:02PM +0900, Ruffalo Lavoisier wrote:
> Signed-off-by: Ruffalo Lavoisier <RuffaloLavoisier@gmail.com>
For obvious reasons, we can't take patches without a changelog :(
> ---
> drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> index d55521b5bdcb..d0321a7565c5 100644
> --- a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> +++ b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> @@ -139,6 +139,10 @@ void device_write(const struct ni_device_routes *dR, FILE *fp)
> int main(void)
> {
> FILE *fp = fopen("ni_values.py", "w");
> + if (fp == NULL) {
> + fprintf(stderr, "Could not open file!");
> + return -1;
> + }
Did you run this through checkpatch.pl? I think you need a blank line
before your check.
And is this fixing a real-world issue, or just something you noticed?
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-06 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 11:54 [PATCH] ni_routing: Check when the file could not be opened Ruffalo Lavoisier
2024-09-06 11:59 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 12:32 Ruffalo Lavoisier
2024-09-05 14:42 Ruffalo Lavoisier
2024-09-06 10:43 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090629-exploit-striving-d2c3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruffalolavoisier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox