Re: [PATCH] ni_routing: Check when the file could not be opened

Greg Kroah-Hartman
2024-09-06T11:59:30Z

On Fri, Sep 06, 2024 at 08:54:02PM +0900, Ruffalo Lavoisier wrote:
> Signed-off-by: Ruffalo Lavoisier <RuffaloLavoisier@gmail.com>

For obvious reasons, we can't take patches without a changelog :(

> ---
> drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> index d55521b5bdcb..d0321a7565c5 100644
> --- a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> +++ b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
> @@ -139,6 +139,10 @@ void device_write(const struct ni_device_routes *dR, FILE *fp)
> int main(void)
> {
> FILE *fp = fopen("ni_values.py", "w");
> + if (fp == NULL) {
> + fprintf(stderr, "Could not open file!");
> + return -1;
> + }

Did you run this through checkpatch.pl? I think you need a blank line
before your check.

And is this fixing a real-world issue, or just something you noticed?

thanks,

greg k-h