Re: [PATCH 2/3] iio: light: opt3001: add support for TI's opt3002 light sensor

Krzysztof Kozlowski
2024-09-05T10:37:41Z

On 05/09/2024 12:20, Emil Gedenryd wrote:
> TI's opt3002 light sensor shares most properties with the opt3001
> model, with the exception of supporting a wider spectrum range.
>
> Add support for TI's opt3002 by extending the TI opt3001 driver.
>
> See https://www.ti.com/product/OPT3002 for more information.
>

...

>
> mutex_init(&opt->lock);
> init_waitqueue_head(&opt->result_ready_queue);
> @@ -769,10 +892,18 @@ static int opt3001_probe(struct i2c_client *client)
> return ret;
>
> iio->name = client->name;
> - iio->channels = opt3001_channels;
> - iio->num_channels = ARRAY_SIZE(opt3001_channels);
> iio->modes = INDIO_DIRECT_MODE;
> iio->info = &opt3001_info;
> + switch (opt->chip_info->model) {
> + case OPT3001:
> + iio->channels = opt3001_channels;
> + iio->num_channels = ARRAY_SIZE(opt3001_channels);
> + break;
> + case OPT3002:
> + iio->channels = opt3002_channels;
> + iio->num_channels = ARRAY_SIZE(opt3002_channels);
> + break;
> + }
>
> ret = devm_iio_device_register(dev, iio);
> if (ret) {
> @@ -826,13 +957,15 @@ static void opt3001_remove(struct i2c_client *client)
> }
>
> static const struct i2c_device_id opt3001_id[] = {
> - { "opt3001" },
> + { "opt3001", 0 },
> + { "opt3002", 1 },

Use the same match data for all ID tables. Otherwise you run into
problems for different match methods.

> { } /* Terminating Entry */
> };
> MODULE_DEVICE_TABLE(i2c, opt3001_id);
>
> static const struct of_device_id opt3001_of_match[] = {
> - { .compatible = "ti,opt3001" },
> + { .compatible = "ti,opt3001", .data = &opt3001_chip_info },
> + { .compatible = "ti,opt3002", .data = &opt3002_chip_info },
Best regards,
Krzysztof