Re: [PATCH 1/3] iio: light: opt3001: add missing full-scale range value

Jonathan Cameron
2024-09-07T17:29:13Z

On Thu, 5 Sep 2024 12:20:45 +0200
Emil Gedenryd <emil.gedenryd@axis.com> wrote:

> The opt3001 driver uses predetermined full-scale range values to
> determine what exponent to use for event trigger threshold values.
> The problem is that one of the values specified in the datasheet is
> missing from the implementation, causing a big gap in settable values.
>
> Add missing full-scale range array value.
>
> Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
I assume this has more of an impact in that if you write values beyond this one
the index will be off by one and the value written to the register
will be incorrect?

Please clarify if that is the case and also add a fixes tag
to the commit that introduced this bug.

Thanks,

Jonathan

> ---
> drivers/iio/light/opt3001.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> index 887c4b776a86..176e54bb48c3 100644
> --- a/drivers/iio/light/opt3001.c
> +++ b/drivers/iio/light/opt3001.c
> @@ -138,6 +138,10 @@ static const struct opt3001_scale opt3001_scales[] = {
> .val = 20966,
> .val2 = 400000,
> },
> + {
> + .val = 41932,
> + .val2 = 800000,
> + },
> {
> .val = 83865,
> .val2 = 600000,
>