From: Riyan Dhiman <riyandhiman14@gmail.com>
To: Markus.Elfring@web.de, rafael@kernel.org, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources_init()
Date: Sat, 7 Sep 2024 21:12:49 +0530 [thread overview]
Message-ID: <20240907154254.4704-1-riyandhiman14@gmail.com> (raw)
In-Reply-To: <c1e8c2f1-d123-4e72-a774-f15daa156afb@web.de>
>> Memory region and IO memory were not released if mtk_cpu_create_freq_table() failed.
>> Added error handling to ensure that IO memory is unmapped and the memory region is
>> released properly to prevent resource leaks and ensure all resources are cleaned up on error.
>
> * Would you like to improve such a change description another bit
Should I elaborate a little more on the issue and explain the fix I have created?
> also according to other line length preferences?
Can you please help me a little bit about this? Is it the character lenght of subject?
should I change it to: cpufreq: mediatek: Fix resource leaks on mtk_cpu_create_freq_table()
failure.
> * How do you think about to add any tags (like "Fixes" and "Cc") accordingly?
Should I change "patch" in subject to "Fixes" or add commit id in the patch message with
fixes tag? Also, whom should add I in cc since I can't find any other email from get_maintainer
script.
Regards,
Riyan Dhiman
next prev parent reply other threads:[~2024-09-07 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 8:40 [PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources_init() Riyan Dhiman
2024-09-07 11:52 ` Markus Elfring
2024-09-07 15:42 ` Riyan Dhiman [this message]
2024-09-07 16:10 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907154254.4704-1-riyandhiman14@gmail.com \
--to=riyandhiman14@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox