From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nick Chan <towinchenmi@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, asahi@lists.linux.dev
Subject: Re: [PATCH 0/3] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs
Date: Sun, 8 Sep 2024 11:01:28 +0200 [thread overview]
Message-ID: <2024090809-crusher-overact-8dcd@gregkh> (raw)
In-Reply-To: <20240908075904.12133-1-towinchenmi@gmail.com>
On Sun, Sep 08, 2024 at 03:50:47PM +0800, Nick Chan wrote:
> Hi,
>
> This series fixes issues with serial on A7-A11 SoCs. The changes do not
> seem to affect existing M1 and up users so they can be applied
> unconditionally.
>
> Firstly, these SoCs require 32-bit writes on the serial port. This only
> manifested in earlycon as reg-io-width in device tree is consulted for
> normal serial writes.
>
> Secondly, A7-A9 SoCs seems to use different bits for RXTO and RXTO
> enable. Accessing these bits in addition to the original RXTO and RXTO
> enable bits will allow serial rx to work correctly on those SoCs.
>
> Changes in v2:
> - Mention A7-A11 in the comment about changing register accesses to
> MMIO32.
>
> - Use BIT() macro for new entries, and change the existing APPLE_S5L_*
> entries for consistency.
Your subject line does not say "v2" :(
Can you resend this as a v3?
thanks,
greg k-h
prev parent reply other threads:[~2024-09-08 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 7:50 [PATCH 0/3] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs Nick Chan
2024-09-08 7:50 ` [PATCH 1/3] tty: serial: samsung: Use BIT() macro for APPLE_S5L_* Nick Chan
2024-09-08 7:50 ` [PATCH 2/3] tty: serial: samsung: Fix A7-A11 serial earlycon SError Nick Chan
2024-09-08 7:50 ` [PATCH 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9 Nick Chan
2024-09-08 9:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090809-crusher-overact-8dcd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=asahi@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox