From: Arnd Bergmann <arnd@kernel.org>
To: Chandan Babu R <chandan.babu@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Darrick J. Wong" <djwong@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anthony Iliopoulos <ailiop@suse.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Kees Cook <kees@kernel.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Josef Bacik <josef@toxicpanda.com>, Jan Kara <jack@suse.cz>,
Amir Goldstein <amir73il@gmail.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] xfs: add CONFIG_MMU dependency
Date: Mon, 9 Sep 2024 11:19:00 +0000 [thread overview]
Message-ID: <20240909111922.249159-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
XFS no longer builds on kernels with MMU disabled:
arm-linux-gnueabi-ld: fs/xfs/xfs_file.o: in function `xfs_write_fault.constprop.0':
xfs_file.c:(.text.xfs_write_fault.constprop.0+0xc): undefined reference to `filemap_fsnotify_fault'
It's rather unlikely that anyone is using this combination,
so just add a Kconfig dependency.
Fixes: 436df5326f57 ("xfs: add pre-content fsnotify hook for write faults")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/xfs/Kconfig | 1 +
lib/Kconfig.debug | 1 +
2 files changed, 2 insertions(+)
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index fffd6fffdce0..1834932a512d 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -2,6 +2,7 @@
config XFS_FS
tristate "XFS filesystem support"
depends on BLOCK
+ depends on MMU
select EXPORTFS
select LIBCRC32C
select FS_IOMAP
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 7c0546480078..8906e2cd1ed5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2862,6 +2862,7 @@ config TEST_KMOD
depends on NETDEVICES && NET_CORE && INET # for TUN
depends on BLOCK
depends on PAGE_SIZE_LESS_THAN_256KB # for BTRFS
+ depends on MMU # for XFS_FS
select TEST_LKM
select XFS_FS
select TUN
--
2.39.2
next reply other threads:[~2024-09-09 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 11:19 Arnd Bergmann [this message]
2024-09-09 13:42 ` [PATCH] xfs: add CONFIG_MMU dependency Jan Kara
2024-09-10 8:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909111922.249159-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=ailiop@suse.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=arnd@arndb.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kees@kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nathan@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox