public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: "Jason J. Herne" <jjherne@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	akrowiak@linux.ibm.com, borntraeger@de.ibm.com,
	agordeev@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH] s390/vfio-ap: Driver feature advertisement
Date: Mon, 9 Sep 2024 14:41:59 +0200	[thread overview]
Message-ID: <20240909124159.11471-B-hca@linux.ibm.com> (raw)
In-Reply-To: <d5911cd9-0365-47e8-91e4-f55317b8040b@linux.ibm.com>

On Mon, Sep 09, 2024 at 08:02:17AM -0400, Jason J. Herne wrote:
> On 9/6/24 6:45 AM, Heiko Carstens wrote:
> > On Thu, Sep 05, 2024 at 08:43:51AM -0400, Jason J. Herne wrote:
> > > Advertise features of the driver for the benefit of automated tooling
> > > like Libvirt and mdevctl.
> > > 
> > > Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
> > > Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> > > ---
> > >   Documentation/arch/s390/vfio-ap.rst | 34 +++++++++++++++++++++++++++++
> > >   drivers/s390/crypto/vfio_ap_drv.c   | 13 +++++++++++
> > >   2 files changed, 47 insertions(+)
> > 
> > Via which tree should this go upstream?
> > 
> I'm not 100% sure. Would s390 next be appropriate?

Well that's up to you to decide; no objection from my side.

FWIW it would be helpful if for future patches there would be a
statement in the cover-letter how this should go upstream. Also
looking at the "To" list of your patch I don't think anybody would
feel like there is a todo :)

That said, you still need to send a v2 which replaces sprintf() with
sysfs_emit().

  reply	other threads:[~2024-09-09 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 12:43 [PATCH] s390/vfio-ap: Driver feature advertisement Jason J. Herne
2024-09-06 10:45 ` Heiko Carstens
2024-09-09 12:02   ` Jason J. Herne
2024-09-09 12:41     ` Heiko Carstens [this message]
2024-09-09 12:49       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240909124159.11471-B-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox