From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1745D1BA27C; Mon, 9 Sep 2024 13:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725889523; cv=none; b=u5fKdIivIBrIeGkaBS6G/e0fq4miLP8onN2APCOrDtmkpQ4CKNF+n+xN4iOpasc3ivOkdIwjUvCPQT/S0Pe0ki6HJ8jWeIe4DPbKRgDFtPvuYIcOKY19EXabjm+mgugp6QrL1d0iaoG2rB+qnH9cOeXF/mQmbEo0VZep81Ecd8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725889523; c=relaxed/simple; bh=DIgINnfFNQiU0BeYyQfLH/SdoJ0HKoSPauy5k5X5lJI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NEwgRMB5ToB6mDhZqPO3MXt4iV3w6h+1iEuG26+CNZdTjfcAmkRYepchMkKGqWwiUMwiqBkJl2Y1jgTXpecIzDDax8lQPFBHIZyphF+Dm8RQ5peiXKimJqTwogvClTw+cySWp4uWcP/1KxKxGnf+G+Zde7oQ01OpFouMmItDhuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=gukUyOix; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gukUyOix" Received: from pendragon.ideasonboard.com (213-229-8-243.static.upcbusiness.at [213.229.8.243]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 542F95A4; Mon, 9 Sep 2024 15:44:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725889443; bh=DIgINnfFNQiU0BeYyQfLH/SdoJ0HKoSPauy5k5X5lJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gukUyOixUwMCQa0c/DYH1Su6z3uDYM0EV12q70+qrExNSRaTa2OSu0LuZgHQIIVB2 PrN55ehOPvvzSOruRl53NJNP00g710Ac0R2a20O4z4w/kPDZH2uT27HO+8ho61CQHU 0NqQFwWWTLZWyUwFHi9ttZfGwn1bsGbbtDhOobkI= Date: Mon, 9 Sep 2024 16:45:16 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Tomi Valkeinen , Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Sakari Ailus , Kieran Bingham , kernel test robot Subject: Re: [PATCH v4 3/4] media: raspberrypi: Add support for RP1-CFE Message-ID: <20240909134516.GA9448@pendragon.ideasonboard.com> References: <20240904-rp1-cfe-v4-3-f1b5b3d69c81@ideasonboard.com> <202409051822.ZzUGw3XQ-lkp@intel.com> <20240905111120.GK16183@pendragon.ideasonboard.com> <40cc1e95-b9fc-4c27-9428-1698d0bf9d25@ideasonboard.com> <763b3147-d7cb-44a7-b73b-8f7f4fd622ab@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Sep 09, 2024 at 03:29:30PM +0200, Jacopo Mondi wrote: > On Mon, Sep 09, 2024 at 01:04:35PM GMT, Tomi Valkeinen wrote: > > On 09/09/2024 12:13, Jacopo Mondi wrote: > > > On Mon, Sep 09, 2024 at 08:22:59AM GMT, Tomi Valkeinen wrote: > > > > On 09/09/2024 08:08, Tomi Valkeinen wrote: > > > > > On 05/09/2024 14:11, Laurent Pinchart wrote: > > > > > > On Thu, Sep 05, 2024 at 06:50:48PM +0800, kernel test robot wrote: > > > > > > > Hi Tomi, > > > > > > > > > > > > > > kernel test robot noticed the following build warnings: > > > > > > > > > > > > > > [auto build test WARNING on 431c1646e1f86b949fa3685efc50b660a364c2b6] > > > > > > > > > > > > > > url:    https://github.com/intel-lab-lkp/linux/commits/Tomi- > > > > > > > Valkeinen/media-uapi-Add-meta-formats-for-PiSP-FE-config-and- > > > > > > > stats/20240904-192729 > > > > > > > base:   431c1646e1f86b949fa3685efc50b660a364c2b6 > > > > > > > patch link:    https://lore.kernel.org/r/20240904-rp1-cfe-v4-3- > > > > > > > f1b5b3d69c81%40ideasonboard.com > > > > > > > patch subject: [PATCH v4 3/4] media: raspberrypi: Add support > > > > > > > for RP1-CFE > > > > > > > config: m68k-allmodconfig (https://download.01.org/0day-ci/ > > > > > > > archive/20240905/202409051822.ZzUGw3XQ-lkp@intel.com/config) > > > > > > > compiler: m68k-linux-gcc (GCC) 14.1.0 > > > > > > > reproduce (this is a W=1 build): > > > > > > > (https://download.01.org/0day-ci/ > > > > > > > archive/20240905/202409051822.ZzUGw3XQ-lkp@intel.com/reproduce) > > > > > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a > > > > > > > new version of > > > > > > > the same patch/commit), kindly add following tags > > > > > > > | Reported-by: kernel test robot > > > > > > > | Closes: https://lore.kernel.org/oe-kbuild- > > > > > > > all/202409051822.ZzUGw3XQ-lkp@intel.com/ > > > > > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > > > > > > > drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2445:12: > > > > > > > > > warning: 'cfe_runtime_resume' defined but not used > > > > > > > > > [-Wunused-function] > > > > > > >      2445 | static int cfe_runtime_resume(struct device *dev) > > > > > > >           |            ^~~~~~~~~~~~~~~~~~ > > > > > > > > > drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2435:12: > > > > > > > > > warning: 'cfe_runtime_suspend' defined but not used > > > > > > > > > [-Wunused-function] > > > > > > >      2435 | static int cfe_runtime_suspend(struct device *dev) > > > > > > >           |            ^~~~~~~~~~~~~~~~~~~ > > > > > > > vim +/cfe_runtime_resume +2445 > > > > > > > drivers/media/platform/raspberrypi/ rp1-cfe/cfe.c > > > > > > > > > > > > The recommended way to fix this is to switch from SET_RUNTIME_PM_OPS() > > > > > > to RUNTIME_PM_OPS() and use pm_ptr() to set .driver.pm. This being said, > > > > > > the driver won't work on a kernel with !CONFIG_PM given how you > > > > > > implemented probe() and remove(). > > > > > > > > > > > > The pisp-be driver suffered from the same issue and Jacopo fixed it in > > > > > > the last version. You can have a look at implement something similar. > > > > > > > > > > I can't right away think of any reason to not just depend on CONFIG_PM > > > > > and be done with it without any tricks. Do you know if there's a reason? > > > > > > We had the same discussion, and even if I would be fine depending on > > > CONFIG_PM, supporting !CONFIG_PM is not that much work, I kept it as > > > an optional dependency (it was suggested during the review as well) > > > > > > > > > > > Also, I don't think pisp-be is correct. It just calls > > > > pispbe_runtime_resume() in probe() to wake the IP up (which only enables > > > > pisp clock), without telling the runtime PM about it. This means the parent > > > > device and the suppliers may not be powered up. > > > > > > Are you referring to the code currently in the tree or to this patch ? > > > https://patchwork.linuxtv.org/project/linux-media/patch/20240904095836.344833-5-jacopo.mondi@ideasonboard.com/ > > > > Ah, I missed that one. > > > > I don't think it fixes the issue I mentioned. If we have PM enabled, and the > > parent device requires powering up for the child device (BE) to be > > accessible, the driver will crash when calling pispbe_hw_init(). I think you > > should call pm_runtime_set_active() before calling pispbe_runtime_resume(). > > As discussed, this is not a problem currently for BE, but indeed you > have a point. > > Sad note: most of all the occurrences of "grep set_active" in > drivers/media/platform/ show that set_active() is used as I've done in > my patch > > > However, you said above that "supporting !CONFIG_PM is not that much work". > > Maybe not. But how much work is it to get it right (for both PM and !PM), > > and make sure it stays right? =). > > > > Just my opinion, but if there are zero use cases for the !PM, I would just > > go with "depends on PM" to keep the driver simpler, less bug-prone, and > > easier to maintain. I'm fine with that, and for platform drivers, that's my preferred option. Sakari ? > I don't see a use case for !PM and we confirmed with RPi they don't > need to support it. During the review of a previous version of the BE > driver iirc I've been asked to support !PM but I'm not sure I recall > the reasons. I hope it wasn't me :-) -- Regards, Laurent Pinchart