From: Conor Dooley <conor@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jisheng Zhang <jszhang@kernel.org>,
Haylen Chu <heylenay@outlook.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] riscv: sophgo: Add pinctrl support for CV1800 series SoC
Date: Tue, 10 Sep 2024 17:13:43 +0100 [thread overview]
Message-ID: <20240910-bust-mulled-e45f6f6ef29d@spud> (raw)
In-Reply-To: <IA1PR20MB4953A0D6A2B73D03BF162671BB992@IA1PR20MB4953.namprd20.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On Tue, Sep 10, 2024 at 06:24:34AM +0800, Inochi Amaoto wrote:
> On Mon, Sep 09, 2024 at 03:41:10PM GMT, Conor Dooley wrote:
> > On Sat, Aug 31, 2024 at 06:38:40AM +0800, Inochi Amaoto wrote:
> > > Add basic pinctrl driver for Sophgo CV1800 series SoCs.
> > > This patch series aims to replace the previous patch from Jisheng [1].
> > > Since the pinctrl of cv1800 has nested mux and its pin definination
> > > is discrete, it is not suitable to use "pinctrl-single" to cover the
> > > pinctrl device.
> > >
> > > This patch require another patch [2] that provides standard attribute
> > > "input-schmitt-microvolt"
> > >
> > > The v4 version is from [3]
> >
> > Which version of this ended up in linux-next? I see a link to v4 in
> > what's been applied, but this v5 was sent before that code was
> > committed.
> >
> > Either way, what's been applied and what's here produce warnings:
> > cv1812h.dtsi:19.28-24.5: Warning (simple_bus_reg): /soc/pinctrl@3008000: simple-bus unit address format error, expected "3001000"
> > cv1800b.dtsi:18.28-23.5: Warning (simple_bus_reg): /soc/pinctrl@3008000: simple-bus unit address format error, expected "3001000"
> >
> > It's just a copy-paste error I would imagine, but please send a fix.
>
> Yes, it is like some copy-paste error, I will fix it.
I'd rather you had sent some follow-up patches, than rebase your tree at
this point in the cycle. I assume you hadn't yet sent that stuff in a PR
to Arnd?
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-09-10 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 22:38 [PATCH v5 0/2] riscv: sophgo: Add pinctrl support for CV1800 series SoC Inochi Amaoto
2024-08-30 22:39 ` [PATCH v5 1/2] riscv: dts: sophgo: cv1800b: add pinctrl support Inochi Amaoto
2024-08-30 22:39 ` [PATCH v5 2/2] riscv: dts: sophgo: cv1812h: " Inochi Amaoto
2024-09-09 14:41 ` [PATCH v5 0/2] riscv: sophgo: Add pinctrl support for CV1800 series SoC Conor Dooley
2024-09-09 22:24 ` Inochi Amaoto
2024-09-10 16:13 ` Conor Dooley [this message]
2024-09-10 22:25 ` Inochi Amaoto
2024-09-11 19:11 ` Conor Dooley
2024-09-11 22:43 ` Inochi Amaoto
2024-09-11 22:51 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910-bust-mulled-e45f6f6ef29d@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heylenay@outlook.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox