From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8BB1A7AE3; Tue, 10 Sep 2024 17:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725988939; cv=none; b=INq6i/Fx71knf71o0/81ry8r/yNxIheL1eRsz6uA/VD9E4OmjARPAnXO/RLTur3xFegOhZ+4fHpFZiI80GMhK4xfHq31uD9ggbCz61NkcMNE2HMGeDmM+LpqXH7ASlIFNSWxzwLhQqikZE0/NmHjh+eqTy7GXG8Y7St+6xTqUTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725988939; c=relaxed/simple; bh=co+0/b4aRDm6iCVskWeVHG7wwfqak69YUvWTAJJ1DXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JQDCqjqWaE83vZrZ1H3ShDdlV2i/JlqvUHQSFc/hUQQVIBI9UC5A5zwGfmdIpfwCDFPpaggpjnJgpeBY2cG3bVl+itJ7CNCxKz7pWrchdLiFfzVdqjyqS/vOsdxTfDr4DMlggLwAy9ypEjTzNBKXW9OAsjmXDEQ+8f6QbYNdzYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gYPs8/F2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gYPs8/F2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFF86C4CECC; Tue, 10 Sep 2024 17:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725988939; bh=co+0/b4aRDm6iCVskWeVHG7wwfqak69YUvWTAJJ1DXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gYPs8/F2By0QeCsvyvugerE/drBTM5pA7l78Oqh+jew7AGHVO0ACMnNrzEVStsgSL T6BLxE5fXsbwcVm89pPtuk1WNAaw/E9yCXbFwFHV4LQ4YQymZqzOybvQylFSjZgyPf BXaxSZE5ex9u1avZQeGGu5ecWxkmhgEEINNlr4yYoVkUp2E/7f39MfOsAHcH0Seb/D jjgf6VoljJ+pT0MNk2C189/AytjrA0MA348zK3LDKnSkVQrSzlU31Nc0uYIfYk6GU/ HZvDARhFBUO1tj1tWsh/L9qX5UO0+kF95VSyhmAnsknO5zLqbs6jS8xPiwTi8fqI4g aLjEzefi219yg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marc Kleine-Budde , Sasha Levin , manivannan.sadhasivam@linaro.org, mailhol.vincent@wanadoo.fr, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.10 02/18] can: mcp251xfd: mcp251xfd_ring_init(): check TX-coalescing configuration Date: Tue, 10 Sep 2024 13:21:47 -0400 Message-ID: <20240910172214.2415568-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240910172214.2415568-1-sashal@kernel.org> References: <20240910172214.2415568-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.9 Content-Transfer-Encoding: 8bit From: Marc Kleine-Budde [ Upstream commit ac2b81eb8b2d104033560daea886ee84531e3d0a ] When changing the interface from CAN-CC to CAN-FD mode the old coalescing parameters are re-used. This might cause problem, as the configured parameters are too big for CAN-FD mode. During testing an invalid TX coalescing configuration has been seen. The problem should be been fixed in the previous patch, but add a safeguard here to ensure that the number of TEF coalescing buffers (if configured) is exactly the half of all TEF buffers. Link: https://lore.kernel.org/all/20240805-mcp251xfd-fix-ringconfig-v1-2-72086f0ca5ee@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c index 4cb79a4f2461..489d1439563a 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c @@ -289,7 +289,7 @@ int mcp251xfd_ring_init(struct mcp251xfd_priv *priv) const struct mcp251xfd_rx_ring *rx_ring; u16 base = 0, ram_used; u8 fifo_nr = 1; - int i; + int err = 0, i; netdev_reset_queue(priv->ndev); @@ -385,10 +385,18 @@ int mcp251xfd_ring_init(struct mcp251xfd_priv *priv) netdev_err(priv->ndev, "Error during ring configuration, using more RAM (%u bytes) than available (%u bytes).\n", ram_used, MCP251XFD_RAM_SIZE); - return -ENOMEM; + err = -ENOMEM; } - return 0; + if (priv->tx_obj_num_coalesce_irq && + priv->tx_obj_num_coalesce_irq * 2 != priv->tx->obj_num) { + netdev_err(priv->ndev, + "Error during ring configuration, number of TEF coalescing buffers (%u) must be half of TEF buffers (%u).\n", + priv->tx_obj_num_coalesce_irq, priv->tx->obj_num); + err = -EINVAL; + } + + return err; } void mcp251xfd_ring_free(struct mcp251xfd_priv *priv) -- 2.43.0