From: Leon Romanovsky <leon@kernel.org>
To: Junxian Huang <huangjunxian6@hisilicon.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next 3/9] RDMA/hns: Fix cpu stuck caused by printings during reset
Date: Wed, 11 Sep 2024 16:25:17 +0300 [thread overview]
Message-ID: <20240911132517.GH4026@unreal> (raw)
In-Reply-To: <4c202653-1ad7-d885-55b7-07c77a549b09@hisilicon.com>
On Wed, Sep 11, 2024 at 09:34:19AM +0800, Junxian Huang wrote:
>
>
> On 2024/9/10 21:09, Leon Romanovsky wrote:
> > On Fri, Sep 06, 2024 at 05:34:38PM +0800, Junxian Huang wrote:
> >> From: wenglianfa <wenglianfa@huawei.com>
> >>
> >> During reset, cmd to destroy resources such as qp, cq, and mr may
> >> fail, and error logs will be printed. When a large number of
> >> resources are destroyed, there will be lots of printings, and it
> >> may lead to a cpu stuck. Replace the printing functions in these
> >> paths with the ratelimited version.
> >
> > At lease some of them if not most should be deleted.
> >
>
> Hi Leon,I wonder if there is a clear standard about whether printing
> can be added?
I don't think so, but there are some guidelines that can help you to do it:
1. Don't print error messages in the fast path.
2. Don't print error messages if other function down in the stack already
printed it.
3. Don't print error messages if it is possible to trigger them from
unprivileged user.
...
>
> Thanks,
> Junxian
>
> > Thanks
next prev parent reply other threads:[~2024-09-11 13:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:34 [PATCH for-next 0/9] RDMA/hns: Bugfixes and one improvement Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 1/9] RDMA/hns: Don't modify rq next block addr in HIP09 QPC Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 2/9] RDMA/hns: Fix Use-After-Free of rsv_qp on HIP08 Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 3/9] RDMA/hns: Fix cpu stuck caused by printings during reset Junxian Huang
2024-09-10 13:09 ` Leon Romanovsky
2024-09-11 1:34 ` Junxian Huang
2024-09-11 13:25 ` Leon Romanovsky [this message]
2024-09-12 1:04 ` Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 4/9] RDMA/hns: Fix the overflow risk of hem_list_calc_ba_range() Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 5/9] RDMA/hns: Fix spin_unlock_irqrestore() called with IRQs enabled Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 6/9] RDMA/hns: Fix VF triggering PF reset in abnormal interrupt handler Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 7/9] RDMA/hns: Fix 1bit-ECC recovery address in non-4K OS Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 8/9] RDMA/hns: Optimize hem allocation performance Junxian Huang
2024-09-06 9:34 ` [PATCH for-next 9/9] RDMA/hns: Fix different dgids mapping to the same dip_idx Junxian Huang
2024-09-10 13:12 ` Leon Romanovsky
2024-10-17 13:21 ` Junxian Huang
2024-10-29 12:40 ` Leon Romanovsky
2024-09-10 13:13 ` [PATCH for-next 0/9] RDMA/hns: Bugfixes and one improvement Leon Romanovsky
2024-09-10 13:13 ` (subset) " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911132517.GH4026@unreal \
--to=leon@kernel.org \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox