Re: [PATCH 5.10 000/186] 5.10.226-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Sep 10, 2024 at 03:52:22PM -0600, Shuah Khan wrote:
> On 9/10/24 15:26, Shuah Khan wrote:
> > On 9/10/24 03:31, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.226 release.
> > > There are 186 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Thu, 12 Sep 2024 09:25:22 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.226-rc1.gz
> > > or in the git tree and branch at:
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > > 
> > > Guillaume Stols <gstols@baylibre.com>
> > >      iio: adc: ad7606: remove frstdata check for serial mode
> > > 
> > 
> > 
> > Kernel: arch/x86/boot/bzImage is ready  (#210)
> > ERROR: modpost: module ad7606_par uses symbol ad7606_reset from namespace IIO_AD7606, but does not import it.
> > make[1]: *** [scripts/Makefile.modpost:123: modules-only.symvers] Error 1
> > make[1]: *** Deleting file 'modules-only.symvers'
> > make: *** [Makefile:1759: modules] Error 2
> > 
> > Same problem. I am building with this commit now and I will
> > update you what happens.
> > 
> 
> Not so easy. Removing this commit gives me the following error.
> drivers/iio/adc/ad7606_par.c: In function ‘ad7606_par16_read_block’:
> drivers/iio/adc/ad7606_par.c:40:25: error: implicit declaration of function ‘ad7606_reset’; did you mean ‘ad7606_probe’? [-Werror=implicit-function-declaration]
>    40 |                         ad7606_reset(st);
>       |                         ^~~~~~~~~~~~

If you remove that commit, this shouldn't be possible as ad7606_par.c
does not call ad7606_reset anymore.  I'll go drop this commit from 5.15
and 5.10 for now until this gets worked out, and that should fix your
build issue.

I'll push out some -rc2 releases to verify.

thanks,

greg k-h