From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: Steven Davis <goldside000@outlook.com>,
hvaibhav.linux@gmail.com, elder@kernel.org, vireshk@kernel.org,
rmfrfs@gmail.com, dtwlin@gmail.com, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Fix capitalization and punctuation inconsistencies
Date: Wed, 11 Sep 2024 15:55:52 +0200 [thread overview]
Message-ID: <2024091142-quill-tableful-3c3e@gregkh> (raw)
In-Reply-To: <Zt7vVaxF2XP-_ZMA@hovoldconsulting.com>
On Mon, Sep 09, 2024 at 02:51:33PM +0200, Johan Hovold wrote:
> On Sun, Sep 01, 2024 at 05:18:59PM -0400, Steven Davis wrote:
> > There were a lot of inconsistencies in outputs and
> > comments, some were properly formatted and
> > capitalized, and some weren't. This patch resolves
> > this by properly formatting the inconsistent comments
> > and outputs.
> >
> > Signed-off-by: Steven Davis <goldside000@outlook.com>
> > ---
> > drivers/staging/greybus/arche-platform.c | 38 ++++++++++++------------
> > drivers/staging/greybus/authentication.c | 6 ++--
> > drivers/staging/greybus/bootrom.c | 16 +++++-----
> > drivers/staging/greybus/light.c | 26 ++++++++--------
> > drivers/staging/greybus/log.c | 10 +++----
> > 5 files changed, 48 insertions(+), 48 deletions(-)
>
> I didn't have time to reply here before Greg picked this one up, but I'm
> gonna ask for this one to be reverted.
>
> The (core) greybus code uses lower case error messages so this patch is
> introducing an inconsistency instead of addressing one.
>
> I just sent a revert here:
>
> https://lore.kernel.org/20240909124853.9213-1-johan@kernel.org
Thanks for that, sorry about missing that.
greg k-h
prev parent reply other threads:[~2024-09-11 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 21:18 [PATCH] staging: greybus: Fix capitalization and punctuation inconsistencies Steven Davis
2024-09-09 12:51 ` Johan Hovold
2024-09-11 13:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091142-quill-tableful-3c3e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=goldside000@outlook.com \
--cc=greybus-dev@lists.linaro.org \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rmfrfs@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox