From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Saravana Kannan <saravanak@google.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] driver core: Don't try to create links if they are not needed
Date: Wed, 11 Sep 2024 16:32:05 +0200 [thread overview]
Message-ID: <2024091152-impound-salt-c748@gregkh> (raw)
In-Reply-To: <20240910130019.35081-1-jonathanh@nvidia.com>
On Tue, Sep 10, 2024 at 02:00:19PM +0100, Jon Hunter wrote:
> The following error messages are observed on boot with the Tegra234
> Jetson AGX Orin board ...
>
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
>
> In the above case, device_link_add() intentionally returns NULL because
> these are SYNC_STATE_ONLY links and the device is already probed.
> Therefore, the above messages are not actually errors. Fix this by
> replicating the test from device_link_add() in the function
> fw_devlink_create_devlink() and don't call device_link_add() if there
> are no links to create.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
What commit id does this fix?
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-11 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:00 [PATCH] driver core: Don't try to create links if they are not needed Jon Hunter
2024-09-11 14:32 ` Greg Kroah-Hartman [this message]
2024-09-16 14:50 ` Jon Hunter
2024-09-16 17:49 ` Greg Kroah-Hartman
2024-10-02 18:30 ` Jon Hunter
2024-10-02 20:38 ` Saravana Kannan
2024-10-03 10:25 ` Jon Hunter
2024-10-03 14:59 ` Nícolas F. R. A. Prado
2024-10-23 1:00 ` Saravana Kannan
2024-10-23 13:24 ` Jon Hunter
2024-10-23 13:58 ` Nícolas F. R. A. Prado
2024-10-23 14:08 ` Jon Hunter
2024-10-23 18:34 ` Saravana Kannan
2024-10-23 18:44 ` Saravana Kannan
2024-10-23 20:28 ` Jon Hunter
2024-10-24 17:07 ` Thierry Reding
2024-10-24 17:10 ` Saravana Kannan
2024-10-23 20:30 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091152-impound-salt-c748@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox