From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Keeping <jkeeping@inmusicbrands.com>
Cc: Roy Luo <royluo@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
yuan linyu <yuanlinyu@hihonor.com>,
Sumit Garg <sumit.garg@linaro.org>,
Krishna Kurapati <quic_kriskura@quicinc.com>,
Paul Cercueil <paul@crapouillou.net>,
Chris Wulff <crwulff@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: core: force synchronous registration
Date: Thu, 12 Sep 2024 15:34:21 +0200 [thread overview]
Message-ID: <2024091210-capitol-quartet-e3d5@gregkh> (raw)
In-Reply-To: <20240912131608.1645554-1-jkeeping@inmusicbrands.com>
On Thu, Sep 12, 2024 at 02:16:07PM +0100, John Keeping wrote:
> Registering a gadget driver is expected to complete synchronously and
> immediately after calling driver_register() this function checks that
> the driver has bound so as to return an error.
>
> Set PROBE_FORCE_SYNCHRONOUS to ensure this is the case even when
> asynchronous probing is set as the default.
>
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
> ---
> drivers/usb/gadget/udc/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index cf6478f97f4a3..a6f46364be65f 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -1696,6 +1696,7 @@ int usb_gadget_register_driver_owner(struct usb_gadget_driver *driver,
> driver->driver.bus = &gadget_bus_type;
> driver->driver.owner = owner;
> driver->driver.mod_name = mod_name;
> + driver->driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
What commit id does this fix?
thanks,
greg k-h
prev parent reply other threads:[~2024-09-12 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 13:16 [PATCH] usb: gadget: core: force synchronous registration John Keeping
2024-09-12 13:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091210-capitol-quartet-e3d5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=crwulff@gmail.com \
--cc=jkeeping@inmusicbrands.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=quic_kriskura@quicinc.com \
--cc=royluo@google.com \
--cc=stern@rowland.harvard.edu \
--cc=sumit.garg@linaro.org \
--cc=yuanlinyu@hihonor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox