* [PATCH] usb: gadget: core: force synchronous registration
@ 2024-09-12 13:16 John Keeping
2024-09-12 13:34 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2024-09-12 13:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: John Keeping, Roy Luo, Alan Stern, yuan linyu, Sumit Garg,
Krishna Kurapati, Paul Cercueil, Chris Wulff, linux-usb,
linux-kernel
Registering a gadget driver is expected to complete synchronously and
immediately after calling driver_register() this function checks that
the driver has bound so as to return an error.
Set PROBE_FORCE_SYNCHRONOUS to ensure this is the case even when
asynchronous probing is set as the default.
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
---
drivers/usb/gadget/udc/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index cf6478f97f4a3..a6f46364be65f 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1696,6 +1696,7 @@ int usb_gadget_register_driver_owner(struct usb_gadget_driver *driver,
driver->driver.bus = &gadget_bus_type;
driver->driver.owner = owner;
driver->driver.mod_name = mod_name;
+ driver->driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
ret = driver_register(&driver->driver);
if (ret) {
pr_warn("%s: driver registration failed: %d\n",
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: core: force synchronous registration
2024-09-12 13:16 [PATCH] usb: gadget: core: force synchronous registration John Keeping
@ 2024-09-12 13:34 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-12 13:34 UTC (permalink / raw)
To: John Keeping
Cc: Roy Luo, Alan Stern, yuan linyu, Sumit Garg, Krishna Kurapati,
Paul Cercueil, Chris Wulff, linux-usb, linux-kernel
On Thu, Sep 12, 2024 at 02:16:07PM +0100, John Keeping wrote:
> Registering a gadget driver is expected to complete synchronously and
> immediately after calling driver_register() this function checks that
> the driver has bound so as to return an error.
>
> Set PROBE_FORCE_SYNCHRONOUS to ensure this is the case even when
> asynchronous probing is set as the default.
>
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
> ---
> drivers/usb/gadget/udc/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index cf6478f97f4a3..a6f46364be65f 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -1696,6 +1696,7 @@ int usb_gadget_register_driver_owner(struct usb_gadget_driver *driver,
> driver->driver.bus = &gadget_bus_type;
> driver->driver.owner = owner;
> driver->driver.mod_name = mod_name;
> + driver->driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-12 13:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 13:16 [PATCH] usb: gadget: core: force synchronous registration John Keeping
2024-09-12 13:34 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox